This is an archive of the discontinued LLVM Phabricator instance.

Differential D68887

[clang-tidy] Copy the Ranges field from the Diagnostic when creating the ClangTidyError
ClosedPublic

Authored by compositeprimes on Oct 11 2019, 1:25 PM.

Details

Reviewers
alexfh
Commits
rG071002ffdb3f: [clang-tidy] Copy the Ranges field from the Diagnostic when creating the…
Summary

Now that https://reviews.llvm.org/D69782 is ready to land, this actually fills in the Ranges in the diagnostic from ClangTidy

Diff Detail

Event Timeline

compositeprimes created this revision.Oct 11 2019, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 11 2019, 1:25 PM
Herald added subscribers: cfe-commits, mgehre. · View Herald Transcript
compositeprimes added a parent revision: D68885: Add a Ranges field to Diagnostic struct.Oct 11 2019, 1:25 PM
MyDeveloperDay retitled this revision from Copy the Ranges field from the Diagnostic when creating the ClangTidyError to [clang-tidy] Copy the Ranges field from the Diagnostic when creating the ClangTidyError.Dec 5 2019, 2:25 AM
Herald added a subscriber: xazax.hun. · View Herald TranscriptDec 5 2019, 2:26 AM
compositeprimes updated this revision to Diff 245915.Feb 21 2020, 10:19 AM
compositeprimes edited the summary of this revision. (Show Details)
compositeprimes edited reviewers, added: alexfh; removed: Restricted Project.Feb 21 2020, 10:21 AM
alexfh accepted this revision.Feb 27 2020, 11:16 AM

LG

This revision is now accepted and ready to land.Feb 27 2020, 11:16 AM
Closed by commit rG071002ffdb3f: [clang-tidy] Copy the Ranges field from the Diagnostic when creating the… (authored by compositeprimes, committed by alexfh). · Explain WhyMar 2 2020, 3:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tools-extra/
clang-tidy/
3 lines

Diff 247593

clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines auto TidyMessage =
? tooling::DiagnosticMessage(Message, Loc.getManager(), Loc) ? tooling::DiagnosticMessage(Message, Loc.getManager(), Loc)
: tooling::DiagnosticMessage(Message); : tooling::DiagnosticMessage(Message);
if (Level == DiagnosticsEngine::Note) { if (Level == DiagnosticsEngine::Note) {
Error.Notes.push_back(TidyMessage); Error.Notes.push_back(TidyMessage);
return; return;
} }
assert(Error.Message.Message.empty() && "Overwriting a diagnostic message"); assert(Error.Message.Message.empty() && "Overwriting a diagnostic message");
Error.Message = TidyMessage; Error.Message = TidyMessage;
for (const CharSourceRange &SourceRange : Ranges) {
Error.Ranges.emplace_back(Loc.getManager(), SourceRange);
}
} }
void emitDiagnosticLoc(FullSourceLoc Loc, PresumedLoc PLoc, void emitDiagnosticLoc(FullSourceLoc Loc, PresumedLoc PLoc,
DiagnosticsEngine::Level Level, DiagnosticsEngine::Level Level,
ArrayRef<CharSourceRange> Ranges) override {} ArrayRef<CharSourceRange> Ranges) override {}
void emitCodeContext(FullSourceLoc Loc, DiagnosticsEngine::Level Level, void emitCodeContext(FullSourceLoc Loc, DiagnosticsEngine::Level Level,
SmallVectorImpl<CharSourceRange> &Ranges, SmallVectorImpl<CharSourceRange> &Ranges,
▲ Show 20 Lines • Show All 659 Lines • Show Last 20 Lines