Differential D68782

[ThinLTO] Import virtual method with single implementation in hybrid mode
ClosedPublic
Actions

Authored by evgeny777 on Oct 10 2019, 4:26 AM.

Details

Reviewers

tejohnson
pcc

Commits

rL375083: [ThinLTO] Import virtual method with single implementation in hybrid mode
rG943afb57aa65: [ThinLTO] Import virtual method with single implementation in hybrid mode

Summary

At the moment this is being done in index based WPD, but would be nice to have in hybrid LTO mode as well.

Diff Detail

Event Timeline

evgeny777 created this revision.Oct 10 2019, 4:26 AM

Herald added subscribers: dexonsmith, steven_wu, hiraditya and 2 others. · View Herald TranscriptOct 10 2019, 4:26 AM

tejohnson added inline comments.Oct 15 2019, 6:32 AM

lib/Transforms/IPO/WholeProgramDevirt.cpp
995	It might be good to add a comment here about why the return value can be ignored (any needed promotion would have been taken care of when the LTO unit was split IIRC).
1859	Probably should go ahead and fold markSummaryHasTypeTestAssumeUsers into addSummaryTypeTestAssumeUser since that is the only callsite now.
test/ThinLTO/X86/devirt_single_hybrid.ll
25	importing it certainly signals that it must have been devirtualized, but it would probably be good to test this explicitly, e.g either checking the call or the pass remark

Addressed

lgtm

This revision is now accepted and ready to land.Oct 15 2019, 8:12 AM

Closed by commit rG943afb57aa65: [ThinLTO] Import virtual method with single implementation in hybrid mode (authored by evgeny777). · Explain WhyOct 17 2019, 12:48 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2019, 12:48 AM

Revision Contents
Changeset List

Path

Size

lib/

Transforms/

IPO/

WholeProgramDevirt.cpp

77 lines

test/

ThinLTO/

X86/

Inputs/

devirt_single_hybrid_bar.ll

58 lines

devirt_single_hybrid_foo.ll

35 lines

devirt_single_hybrid.ll

55 lines

Diff 225035

lib/Transforms/IPO/WholeProgramDevirt.cpp

Loading...

test/ThinLTO/X86/Inputs/devirt_single_hybrid_bar.ll

Loading...

test/ThinLTO/X86/Inputs/devirt_single_hybrid_foo.ll

Loading...

test/ThinLTO/X86/devirt_single_hybrid.ll

Loading...