At the moment this is being done in index based WPD, but would be nice to have in hybrid LTO mode as well.
Details
Details
Diff Detail
Diff Detail
Event Timeline
lib/Transforms/IPO/WholeProgramDevirt.cpp | ||
---|---|---|
995 | It might be good to add a comment here about why the return value can be ignored (any needed promotion would have been taken care of when the LTO unit was split IIRC). | |
1859 | Probably should go ahead and fold markSummaryHasTypeTestAssumeUsers into addSummaryTypeTestAssumeUser since that is the only callsite now. | |
test/ThinLTO/X86/devirt_single_hybrid.ll | ||
25 | importing it certainly signals that it must have been devirtualized, but it would probably be good to test this explicitly, e.g either checking the call or the pass remark |