This is an archive of the discontinued LLVM Phabricator instance.

Differential D68726

[libc] Do not add unittests LLVM_INCLUDE_TESTS is OFF.
ClosedPublic

Authored by sivachandra on Oct 9 2019, 1:37 PM.

Download Raw Diff

Details

Reviewers

Commits

rGc1157d1e77c3: [libc] Do not add unittests if LLVM_INCLUDE_TESTS is OFF.
rL374925: [libc] Do not add unittests if LLVM_INCLUDE_TESTS is OFF.

Diff Detail

Repository

rG LLVM Github Monorepo

Build Status

Buildable 39258
Build 39274: arc lint + arc unit

Event Timeline

sivachandra created this revision.Oct 9 2019, 1:37 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2019, 1:37 PM

Herald added subscribers: libc-commits, tschuett, mgorny. · View Herald Transcript

Harbormaster completed remote builds in B39258: Diff 224144.Oct 9 2019, 1:37 PM

Hopefully this should fix the problem you reported here: https://reviews.llvm.org/D67867

Yes, it does! I can approve this if you need it but I am not an expect in cmake so I cannot comment on how proper this is.

nathanchance accepted this revision.Oct 13 2019, 6:59 PM

This revision is now accepted and ready to land.Oct 13 2019, 6:59 PM

Closed by commit rGc1157d1e77c3: [libc] Do not add unittests if LLVM_INCLUDE_TESTS is OFF. (authored by sivachandra). · Explain WhyOct 15 2019, 10:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

libc/

cmake/

modules/

LLVMLibCRules.cmake

4 lines

Diff 224144

libc/cmake/modules/LLVMLibCRules.cmake

	Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Lines		function(add_entrypoint_library target_name)
	add_custom_target(			add_custom_target(
	${target_name}			${target_name}
	ALL			ALL
	DEPENDS ${library_file}			DEPENDS ${library_file}
	)			)
	endfunction(add_entrypoint_library)			endfunction(add_entrypoint_library)

	function(add_libc_unittest target_name)			function(add_libc_unittest target_name)
				if(NOT LLVM_INCLUDE_TESTS)
				return()
				endif()

	cmake_parse_arguments(			cmake_parse_arguments(
	"LIBC_UNITTEST"			"LIBC_UNITTEST"
	"" # No optional arguments			"" # No optional arguments
	"SUITE" # Single value arguments			"SUITE" # Single value arguments
	"SRCS;HDRS;DEPENDS" # Multi-value arguments			"SRCS;HDRS;DEPENDS" # Multi-value arguments
	${ARGN}			${ARGN}
	)			)
	if(NOT LIBC_UNITTEST_SRCS)			if(NOT LIBC_UNITTEST_SRCS)
	▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines