This is an archive of the discontinued LLVM Phabricator instance.

Differential D6869

.gitignore: add some rules to clarify 'arc diff'
ClosedPublic

Authored by artagnon on Jan 7 2015, 11:39 AM.

Details

Reviewers
chandlerc
beanz
• ddunbar
Bigcheese
Summary

Often, we miss committing new files, and 'arc diff' is supposed to warn
us about this. Unfortunately, because of the massive output of the
command (so many untracked files not in .gitignore), we tend to ignore
it and lose information. Fix this by adding some rules: works if the
build directory is /build.

Diff Detail

Event Timeline

artagnon updated this revision to Diff 17868.Jan 7 2015, 11:39 AM
artagnon retitled this revision from to .gitignore: add some rules to clarify 'arc diff'.
artagnon updated this object.
artagnon edited the test plan for this revision. (Show Details)
artagnon added reviewers: • ddunbar, Bigcheese.
artagnon added a subscriber: Unknown Object (MLST).
beanz added a subscriber: beanz.Jan 7 2015, 12:42 PM

There really isn't anything offensive here, but is there a reason all your directories are starting with '/'? The rest of the file omits the leading slashes, so it might be nice if you kept consistent.

.gitignore
46

Do most people do in-tree builds? I exclusively do out of tree CMake/configure.

artagnon added a reviewer: beanz.Jan 7 2015, 12:56 PM
artagnon removed a subscriber: beanz.
artagnon added a comment.Jan 7 2015, 1:00 PM

The leading '/' means anchored to toplevel: so, 'foo' matches the file or directory 'foo' in any subdirectory of the tree, '/foo' matches the file or directory 'foo' at the toplevel of the tree. Many of the other rules should probably be updated to contain the leading '/' as well, but that's the subject of another change.

.gitignore
46

Not sure about this. I thought in-tree meant a Debug+Asserts/ directory in each subdirectory of the tree. But if the style is to take the build/ directory out of the source tree entirely, I'll remove this rule and do that from now on.

artagnon updated this revision to Diff 17872.Jan 7 2015, 1:07 PM

Remove in-tree build/ directory rule.

artagnon added a reviewer: chandlerc.Jan 7 2015, 2:19 PM
beanz accepted this revision.Jan 9 2015, 2:13 PM
beanz edited edge metadata.

Sorry for the delay, LGTM.

This revision is now accepted and ready to land.Jan 9 2015, 2:13 PM
artagnon closed this revision.Jan 10 2015, 12:01 PM

Revision Contents

PathSize
7 lines

Diff 17872

.gitignore

Show All 18 Lines
.*.swp .*.swp
.sw? .sw?
#OS X specific files. #OS X specific files.
.DS_store .DS_store
#==============================================================================# #==============================================================================#
# Explicit files to ignore (only matches one). # Explicit files to ignore (only matches one).
#==============================================================================# #==============================================================================#
# Various tag programs
/tags
/TAGS
/GPATH
/GRTAGS
/GSYMS
/GTAGS
.gitusers .gitusers
autom4te.cache autom4te.cache
cscope.files cscope.files
cscope.out cscope.out
autoconf/aclocal.m4 autoconf/aclocal.m4
autoconf/autom4te.cache autoconf/autom4te.cache
compile_commands.json compile_commands.json
#==============================================================================# #==============================================================================#
# Directories to ignore (do not add trailing '/'s, they skip symlinks). # Directories to ignore (do not add trailing '/'s, they skip symlinks).
#==============================================================================# #==============================================================================#
# External projects that are tracked independently. # External projects that are tracked independently.
projects/* projects/*
beanzUnsubmitted
Not Done
ReplyInline Actions

Do most people do in-tree builds? I exclusively do out of tree CMake/configure.

beanz: Do most people do in-tree builds? I exclusively do out of tree CMake/configure.
artagnonAuthorUnsubmitted
Not Done
ReplyInline Actions

Not sure about this. I thought in-tree meant a Debug+Asserts/ directory in each subdirectory of the tree. But if the style is to take the build/ directory out of the source tree entirely, I'll remove this rule and do that from now on.

artagnon: Not sure about this. I thought in-tree meant a Debug+Asserts/ directory in each subdirectory of…
!projects/CMakeLists.txt !projects/CMakeLists.txt
!projects/Makefile !projects/Makefile
# Clang, which is tracked independently. # Clang, which is tracked independently.
tools/clang tools/clang
# LLDB, which is tracked independently. # LLDB, which is tracked independently.
tools/lldb tools/lldb
# lld, which is tracked independently. # lld, which is tracked independently.
tools/lld tools/lld
Show All 10 Lines