Page MenuHomePhabricator

ARM] Fix arm_neon.h with -flax-vector-conversions=none
ClosedPublic

Authored by efriedma on Oct 8 2019, 8:29 PM.

Details

Summary

Really, we were already 99% of the way there; just needed a couple minor fixes that affected 64-bit-only builtins. Based on D61717.

Note that the change to builtin_str changes the type of a few __builtin_neon_* intrinsics that had the "wrong" type.

Fixes https://bugs.llvm.org/show_bug.cgi?id=43341

Diff Detail

Event Timeline

efriedma created this revision.Oct 8 2019, 8:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2019, 8:29 PM
SjoerdMeijer accepted this revision.Oct 9 2019, 12:15 AM

Nice one, thanks for fixing! I didn't have the bandwidth to look into this.

This revision is now accepted and ready to land.Oct 9 2019, 12:15 AM
rsmith accepted this revision.Oct 9 2019, 10:24 AM

Thank you!

We also have a hack in the ARM and AArch64 target info to set the default for lax vector conversions back to "all" when NEON is enabled that can now be removed.

This revision was automatically updated to reflect the committed changes.

We also have a hack in the ARM and AArch64 target info to set the default for lax vector conversions back to "all" when NEON is enabled that can now be removed.

Never mind, looks like I didn't get round to landing D67678 yet. =)