[tsan, go] fix Go windows build

[randall77]

Summary

Don't use weak exports when building tsan into a shared library for Go. gcc can't handle the pragmas used to make the weak references.

Include files that have been added since the last update to build.bat. (We should really find a better way to list all the files needed.)

Add windows version defines (WINVER and _WIN32_WINNT) to get AcquireSRWLockExclusive and ReleaseSRWLockExclusive defined.

Define GetProcessMemoryInfo to use the kernel32 version. This is kind of a hack, the windows header files should do this translation for us. I think we're not in the right family partition (we're using Desktop, but that translation only happens for App and System partitions???), but hacking the family partition seems equally gross and I have no idea what the consequences of that might be.

Patch by Keith Randall.

[randall77]

This change replaces D68277.

[randall77]

Missing two -D options

[randall77]

rebasing attempt 1

[vitalybuka]

lib/tsan/go/build.bat

52 ↗

(On Diff #223670)

For consistency could you split these 1-per-line?

[vitalybuka]

lib/tsan/go/build.bat

52 ↗

(On Diff #223670)

Ah, don't bother
You likely have no commiter access, so someone else will have to land it.
I'll reformat and land.

[randall77]

Vitaly, thanks for all your help!

compiler-rt/lib/sanitizer_common/sanitizer_win_defs.h

 #else
 #define WIN_EXPORT_PREFIX WIN_SYM_PREFIX
 #endif
 
 // Intermediate macro to ensure the parameter is expanded before stringified.
 #define STRINGIFY_(A) #A
 #define STRINGIFY(A) STRINGIFY_(A)
 
+#if !SANITIZER_GO
+
 // ----------------- A workaround for the absence of weak symbols --------------
 // We don't have a direct equivalent of weak symbols when using MSVC, but we can
 // use the /alternatename directive to tell the linker to default a specific
 // symbol to a specific value.
 // Take into account that this is a pragma directive for the linker, so it will
 // be ignored by the compiler and the function will be marked as UNDEF in the
 // symbol table of the resulting object file. The linker won't find the default
 // implementation until it links with that object file.

 //
 //   // client.cc
 //   WIN_WEAK_IMPORT_DEF(compare)
 //   // We override and export compare:
 //   extern "C" __declspec(dllexport) bool compare (int a, int b) {
 //     return a >= b;
 //   }
 //
+
+#else // SANITIZER_GO
+
+// Go neither needs nor wants weak references.
+// The shenanigans above don't work for gcc.
+# define WIN_WEAK_EXPORT_DEF(ReturnType, Name, ...)                            \
+  extern "C" ReturnType Name(__VA_ARGS__)
+
+#endif // SANITIZER_GO
+
 #endif // SANITIZER_WINDOWS
 #endif // SANITIZER_WIN_DEFS_H

compiler-rt/lib/tsan/go/build.bat

type ^
   ..\rtl\tsan_platform_windows.cpp ^
   ..\..\sanitizer_common\sanitizer_win.cpp ^
   ..\..\sanitizer_common\sanitizer_deadlock_detector1.cpp ^
   ..\..\sanitizer_common\sanitizer_stackdepot.cpp ^
   ..\..\sanitizer_common\sanitizer_persistent_allocator.cpp ^
   ..\..\sanitizer_common\sanitizer_flag_parser.cpp ^
   ..\..\sanitizer_common\sanitizer_symbolizer.cpp ^
   ..\..\sanitizer_common\sanitizer_termination.cpp ^
+  ..\..\sanitizer_common\sanitizer_file.cpp ^
+  ..\..\sanitizer_common\sanitizer_symbolizer_report.cpp ^
+  ..\rtl\tsan_external.cpp ^
   > gotsan.cpp
 
 gcc ^
   -c ^
   -o race_windows_amd64.syso ^
   gotsan.cpp ^
   -I..\rtl ^
   -I..\.. ^
   -I..\..\sanitizer_common ^
   -I..\..\..\include ^
   -m64 ^
   -Wall ^
   -fno-exceptions ^
   -fno-rtti ^
   -DSANITIZER_GO=1 ^
+  -DWINVER=0x0600 ^
+  -D_WIN32_WINNT=0x0600 ^
+  -DGetProcessMemoryInfo=K32GetProcessMemoryInfo ^
   -Wno-error=attributes ^
   -Wno-attributes ^
   -Wno-format ^
   -Wno-maybe-uninitialized ^
   -DSANITIZER_DEBUG=0 ^
   -O3 ^
   -fomit-frame-pointer ^
   -std=c++11