This is an archive of the discontinued LLVM Phabricator instance.

Differential D68594

[llvm-lipo] Add TextAPI to LINK_COMPONENTS
ClosedPublic

Authored by aheejin on Oct 7 2019, 2:21 PM.

Details

Reviewers
alexander-shaposhnikov
Commits
rGae5bad7277f4: [llvm-lipo] Add TextAPI to LINK_COMPONENTS
rL373974: [llvm-lipo] Add TextAPI to LINK_COMPONENTS
Summary

D68319 uses MachO::getCPUTypeFromArchitecture and without this builds
with -DBUILD_SHARED_LIBS=ON fail.

Diff Detail

Event Timeline

aheejin created this revision.Oct 7 2019, 2:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 2:21 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
aheejin added a comment.EditedOct 7 2019, 3:06 PM

Merging this, because builds are crashing.

alexander-shaposhnikov accepted this revision.Oct 7 2019, 7:17 PM

ok, thanks

This revision is now accepted and ready to land.Oct 7 2019, 7:17 PM
Harbormaster completed remote builds in B39105: Diff 223657.Oct 7 2019, 10:05 PM
Closed by commit rL373974: [llvm-lipo] Add TextAPI to LINK_COMPONENTS (authored by aheejin). · Explain WhyOct 7 2019, 10:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
tools/
llvm-lipo/
1 line

Diff 223657

llvm/tools/llvm-lipo/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
Object Object
Option Option
Support Support
TextAPI
) )
set(LLVM_TARGET_DEFINITIONS LipoOpts.td) set(LLVM_TARGET_DEFINITIONS LipoOpts.td)
tablegen(LLVM LipoOpts.inc -gen-opt-parser-defs) tablegen(LLVM LipoOpts.inc -gen-opt-parser-defs)
add_public_tablegen_target(LipoOptsTableGen) add_public_tablegen_target(LipoOptsTableGen)
add_llvm_tool(llvm-lipo add_llvm_tool(llvm-lipo
llvm-lipo.cpp llvm-lipo.cpp
DEPENDS DEPENDS
LipoOptsTableGen LipoOptsTableGen
) )
if(LLVM_INSTALL_CCTOOLS_SYMLINKS) if(LLVM_INSTALL_CCTOOLS_SYMLINKS)
add_llvm_tool_symlink(lipo llvm-lipo) add_llvm_tool_symlink(lipo llvm-lipo)
endif() endif()