Page MenuHomePhabricator

[Bitcode] Update naming of UNOP_NEG to UNOP_FNEG
ClosedPublic

Authored by cameron.mcinally on Oct 7 2019, 1:02 PM.

Details

Summary

As requested in D53877 post-commit review, update naming of UNOP_NEG to UNOP_FNEG.

Also add UnaryOperator to the LLVMIsA##name macro. There does not appear to be existing tests for the LLVMIsA* functions, so I'm not sure how to test it.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
lebedev.ri accepted this revision.Oct 7 2019, 1:26 PM

Thank you, LG!

llvm/include/llvm-c/Core.h
1546 ↗(On Diff #223637)

Commit this separately? "llvm-c: there's Unary operator"
I don't know what else might be missing for C API though.

This revision is now accepted and ready to land.Oct 7 2019, 1:26 PM
lebedev.ri added a subscriber: whitequark.

@whitequark might know about C API

Closed by commit rL373958: [Bitcode] Update naming of UNOP_NEG to UNOP_FNEG (authored by mcinally, committed by ). · Explain WhyOct 7 2019, 10:19 PM
This revision was automatically updated to reflect the committed changes.