This is an archive of the discontinued LLVM Phabricator instance.

[Remarks] Pass StringBlockValue as StringRef.
ClosedPublic

Authored by fhahn on Oct 7 2019, 5:27 AM.

Details

Summary

After changing the remark serialization, we now pass StringRefs to the
serializer. We should use StringRef for StringBlockVal, to avoid
creating temporary objects, which then cause StringBlockVal.Value to
point to invalid memory.

Event Timeline

fhahn created this revision.Oct 7 2019, 5:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 5:27 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
thegameg accepted this revision.Oct 7 2019, 8:57 AM

LGTM, thanks.

This revision is now accepted and ready to land.Oct 7 2019, 8:57 AM
This revision was automatically updated to reflect the committed changes.