[PATCH 20/38] [noalias] D9386: llvm.noalias - CaptureTracking needs to look through them

[jeroen.dobbelaere]

Summary

This is part of the series started by D68484.

Rebase of D9386

[jeroen.dobbelaere]

Rebased

[jeroen.dobbelaere]

For review convenience, all changes related to the original local restrict patches have now been incorporated in the full restrict patch series.

llvm/lib/Analysis/CaptureTracking.cpp

 #include "llvm/Analysis/AliasAnalysis.h"
 #include "llvm/Analysis/CFG.h"
 #include "llvm/Analysis/OrderedBasicBlock.h"
 #include "llvm/Analysis/ValueTracking.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/Dominators.h"
 #include "llvm/IR/Instructions.h"
 #include "llvm/IR/IntrinsicInst.h"
+#include "llvm/IR/Intrinsics.h"
 
 using namespace llvm;
 
 CaptureTracker::~CaptureTracker() {}
 
 bool CaptureTracker::shouldExplore(const Use *U) { return true; }
 
 bool CaptureTracker::isDereferenceableOrNull(Value *O, const DataLayout &DL) {
void llvm::PointerMayBeCaptured(const Value *V, CaptureTracker *Tracker,
   while (!Worklist.empty()) {
     const Use *U = Worklist.pop_back_val();
     Instruction *I = cast<Instruction>(U->getUser());
     V = U->get();
 
     switch (I->getOpcode()) {
     case Instruction::Call:
     case Instruction::Invoke: {
+      if (auto *II = dyn_cast<IntrinsicInst>(I))
+        if (II->getIntrinsicID() == Intrinsic::noalias) {
+          AddUses(I);
+          break;
+        }
+
       auto *Call = cast<CallBase>(I);
       // Not captured if the callee is readonly, doesn't return a copy through
       // its return value and doesn't unwind (a readonly function can leak bits
       // by throwing an exception or not depending on the input value).
       if (Call->onlyReadsMemory() && Call->doesNotThrow() &&
           Call->getType()->isVoidTy())
         break;
 

llvm/test/Transforms/FunctionAttrs/nocapture.ll

l:
   %tmp = bitcast i32* %x to i32*    ; <i32*> [#uses=2]
   %tmp2 = select i1 %b, i32* %tmp, i32* %y
   %val = load i32, i32* %tmp2    ; <i32> [#uses=1]
   store i32 0, i32* %tmp
   store i32* %y, i32** @g
   ret i32 %val
 }
 
+; EITHER: define i32 @nc1a(i32* %q, i32* nocapture %p, i1 %b)
+define i32 @nc1a(i32* %q, i32* %p, i1 %b) {
+e:
+        %pa = call i32* @llvm.noalias.p0i32(i32* %p, metadata !1)
+  br label %l
+l:
+  %x = phi i32* [ %pa, %e ]
+  %y = phi i32* [ %q, %e ]
+  %tmp = bitcast i32* %x to i32*    ; <i32*> [#uses=2]
+  %tmp2 = select i1 %b, i32* %tmp, i32* %y
+  %val = load i32, i32* %tmp2    ; <i32> [#uses=1]
+  store i32 0, i32* %tmp
+  store i32* %y, i32** @g
+  ret i32 %val
+}
+
 ; EITHER: define i32 @nc1_addrspace(i32* %q, i32 addrspace(1)* nocapture %p, i1 %b)
 define i32 @nc1_addrspace(i32* %q, i32 addrspace(1)* %p, i1 %b) {
 e:
   br label %l
 l:
   %x = phi i32 addrspace(1)* [ %p, %e ]
   %y = phi i32* [ %q, %e ]
   %tmp = addrspacecast i32 addrspace(1)* %x to i32*    ; <i32*> [#uses=2]

 ; ATTRIBUTOR: define i8* @test_returned2(i8* nocapture readonly %A, i8* readonly returned %B)
 entry:
   %p = call i8* @unknownpi8pi8(i8* %A, i8* %B) nounwind readonly
   ret i8* %p
 }
 
 declare i8* @llvm.launder.invariant.group.p0i8(i8*)
 declare i8* @llvm.strip.invariant.group.p0i8(i8*)
+
+declare i32* @llvm.noalias.p0i32(i32*, metadata) nounwind
+
+!0 = !{!0, !"some domain"}
+!1 = !{!1, !0, !"some scope"}