This is an archive of the discontinued LLVM Phabricator instance.

Differential D68482

[clang] fix a typo from r372531
ClosedPublic

Authored by ychen on Oct 4 2019, 1:34 PM.

Details

Reviewers
xbolva00
Commits
rG442ddffe138a: [clang] fix a typo from r372531
rL373792: [clang] fix a typo from r372531
rC373792: [clang] fix a typo from r372531

Diff Detail

Event Timeline

ychen created this revision.Oct 4 2019, 1:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 1:34 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B39011: Diff 223280.Oct 4 2019, 1:35 PM
xbolva00 accepted this revision.Oct 4 2019, 1:50 PM

Thank you

This revision is now accepted and ready to land.Oct 4 2019, 1:50 PM
Closed by commit rL373792: [clang] fix a typo from r372531 (authored by yuanfang). · Explain WhyOct 4 2019, 2:40 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 2:40 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
lib/
Sema/
2 lines
test/
Sema/
2 lines

Diff 223280

clang/lib/Sema/SemaChecking.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 11,360 Lines • ▼ Show 20 Lines if (const auto *CO = dyn_cast<ConditionalOperator>(E)) {
const auto *LHS = getIntegerLiteral(CO->getTrueExpr()); const auto *LHS = getIntegerLiteral(CO->getTrueExpr());
const auto *RHS = getIntegerLiteral(CO->getFalseExpr()); const auto *RHS = getIntegerLiteral(CO->getFalseExpr());
if (!LHS || !RHS) if (!LHS || !RHS)
return; return;
if ((LHS->getValue() == 0 || LHS->getValue() == 1) && if ((LHS->getValue() == 0 || LHS->getValue() == 1) &&
(RHS->getValue() == 0 || RHS->getValue() == 1)) (RHS->getValue() == 0 || RHS->getValue() == 1))
// Do not diagnose common idioms. // Do not diagnose common idioms.
return; return;
if (LHS->getValue() != 0 && LHS->getValue() != 0) if (LHS->getValue() != 0 && RHS->getValue() != 0)
S.Diag(ExprLoc, diag::warn_integer_constants_in_conditional_always_true); S.Diag(ExprLoc, diag::warn_integer_constants_in_conditional_always_true);
} }
} }
static void CheckImplicitConversion(Sema &S, Expr *E, QualType T, static void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
SourceLocation CC, SourceLocation CC,
bool *ICContext = nullptr, bool *ICContext = nullptr,
bool IsListInit = false) { bool IsListInit = false) {
▲ Show 20 Lines • Show All 3,229 Lines • Show Last 20 Lines

clang/test/Sema/warn-integer-constants-in-ternary.c

Show All 12 Lines
#else #else
typedef _Bool boolean; typedef _Bool boolean;
#endif #endif
void test(boolean a) { void test(boolean a) {
boolean r; boolean r;
r = a ? (1) : TWO; r = a ? (1) : TWO;
r = a ? 3 : TWO; // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}} r = a ? 3 : TWO; // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}}
r = a ? -2 : 0; // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}} r = a ? -2 : 0;
r = a ? 3 : -2; // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}} r = a ? 3 : -2; // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}}
r = a ? 0 : TWO; r = a ? 0 : TWO;
r = a ? 3 : ONE; // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}} r = a ? 3 : ONE; // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}}
r = a ? ONE : 0; r = a ? ONE : 0;
r = a ? 0 : -0; r = a ? 0 : -0;
r = a ? 1 : 0; r = a ? 1 : 0;
r = a ? ONE : 0; r = a ? ONE : 0;
r = a ? ONE : ONE; r = a ? ONE : ONE;
r = TERN(a, 4, 8); // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}} r = TERN(a, 4, 8); // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}}
r = TERN(a, -1, -8); // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}} r = TERN(a, -1, -8); // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}}
} }