Page MenuHomePhabricator

[AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a
ClosedPublic

Authored by nickdesaulniers on Oct 2 2019, 1:37 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

nickdesaulniers created this revision.Oct 2 2019, 1:37 PM
  • git-clang-format HEAD~
Harbormaster completed remote builds in B38909: Diff 222902.
t.p.northover accepted this revision.Oct 3 2019, 1:03 AM

Looks reasonable to me.

This revision is now accepted and ready to land.Oct 3 2019, 1:03 AM
nickdesaulniers edited the summary of this revision. (Show Details)Oct 3 2019, 8:58 AM

Sorry, this breaks:

Failing Tests (2):

LLVM :: MC/AArch64/basic-a64-instructions.s
LLVM :: MC/Disassembler/AArch64/basic-a64-instructions.txt

Let me fix those up then ask for re-review.

  • fix two unit tests that needed updating
t.p.northover accepted this revision.Oct 3 2019, 10:33 AM

Fair enough. Still fine I think.

This revision was automatically updated to reflect the committed changes.