[gdb-remote] process properly effective uid

[wallace]

Summary

Someone wrote SetEffectiveSetEffectiveGroupID instead of SetEffectiveUserID.

After this fix, the android process list can show user names, e.g.

PID    PARENT USER       GROUP      EFF USER   EFF GROUP  TRIPLE                               ARGUMENTS
====== ====== ========== ========== ========== ========== ============================== ============================
529    1      root       0          root       0                                         /sbin/ueventd

[labath]

Someone also didn't write a test for that. :) Let's not make the same mistake. The same two options I mentioned in D68293 should apply here too, though for this case, I would slightly prefer the c++ unit test route, as it will isolate you from the weirdness of the host platforms and their uid handling.

[wallace]

added a test

[wallace]

already committed

lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py

 import lldb
 import binascii
 import os
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test.decorators import *
 from gdbclientutils import *
 
 
 class TestPlatformClient(GDBRemoteTestBase):
 
-    def test_process_list_with_all_users(self):
+    def test_process_list(self):
         """Test connecting to a remote linux platform"""
 
         class MyResponder(MockGDBServerResponder):
             def qfProcessInfo(self, packet):
                 if "all_users:1" in packet:
-                    return "pid:10;ppid:1;uid:1;gid:1;euid:1;egid:1;name:" + binascii.hexlify("/a/process") + ";args:"
+                    return "pid:10;ppid:1;uid:2;gid:3;euid:4;egid:5;name:" + binascii.hexlify("/a/process") + ";args:"
                 else:
                     return "E04"
 
         self.server.responder = MyResponder()
 
         self.runCmd("platform select remote-linux")
 
         try:
             self.runCmd("platform connect connect://localhost:%d" %
                         self.server.port)
             self.assertTrue(self.dbg.GetSelectedPlatform().IsConnected())
             self.expect("platform process list -x",
                         startstr="1 matching process was found", endstr="process" + os.linesep)
+            self.expect("platform process list -xv",
+                        substrs=[
+                            "PID    PARENT USER       GROUP      EFF USER   EFF GROUP",
+                            "10     1      2          3          4          5"])
             self.expect("platform process list",
                         error="error: no processes were found on the \"remote-linux\" platform")
         finally:
             self.runCmd("platform disconnect")

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

while (response.GetNameColonValue(name, value)) {
         process_info.SetParentProcessID(pid);
       } else if (name.equals("uid")) {
         uint32_t uid = UINT32_MAX;
         value.getAsInteger(0, uid);
         process_info.SetUserID(uid);
       } else if (name.equals("euid")) {
         uint32_t uid = UINT32_MAX;
         value.getAsInteger(0, uid);
-        process_info.SetEffectiveGroupID(uid);
+        process_info.SetEffectiveUserID(uid);
       } else if (name.equals("gid")) {
         uint32_t gid = UINT32_MAX;
         value.getAsInteger(0, gid);
         process_info.SetGroupID(gid);
       } else if (name.equals("egid")) {
         uint32_t gid = UINT32_MAX;
         value.getAsInteger(0, gid);
         process_info.SetEffectiveGroupID(gid);