Page MenuHomePhabricator

[JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationClient
ClosedPublic

Authored by JDevlieghere on Oct 1 2019, 2:28 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Oct 1 2019, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2019, 2:28 PM
labath accepted this revision.Oct 2 2019, 12:38 AM

LG, though I'm not sure whether using using namespace llvm is such a good idea. There's a fair number of classes with identical names in llvm and lldb_private namespaces. As we start using more of llvm, we will start hitting conflicts. E.g., I've had to handle a bunch of conflicts when I made lldb_private::DataExtractor convertible to llvm::DataExtractor (which made the second name visible nearly everywhere). For this particular case a namespace alias (namespace json = llvm::json) might be a better option.

This revision is now accepted and ready to land.Oct 2 2019, 12:38 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2019, 11:01 AM