[lldb] clean up lldb/scripts a little bit

[hhb]

Summary

No functional change.

[mgorny]

Without testing, the changes LGTM. However, please wait for Pavel to review this as well.

[labath]

I don't think this is fully right. We did have a separate xcode build, but it was removed a couple of months ago. Instead the regular cmake build supports building a macos-style framework (and I believe it does that regardless of which generator is used). So all that's needed here is to replace references to xcode with some blurb about "frameworks", and instead of "built by llvm" we should just say that we're building with a traditional unix layout. @sgraenitz might know more details here...

[hhb]

Fix comment

lldb/scripts/Python/finishSwigPythonLLDB.py

 """ Python SWIG post process script for each language
 
     --------------------------------------------------------------------------
     File:           finishSwigPythonLLDB.py
 
     Overview:       Python script(s) to post process SWIG Python C++ Script
                     Bridge wrapper code on the Windows/LINUX/OSX platform.
-                    The Python scripts are equivalent to the shell script (.sh)
-                    files.
                     For the Python script interpreter (external to liblldb) to
                     be able to import and use the lldb module, there must be
                     two files, lldb.py and _lldb.so, that it can find. lldb.py
                     is generated by SWIG at the same time it generates the C++
                     file.  _lldb.so is actually a symlink file that points to
                     the LLDB shared library/framework.
                     The Python script interpreter needs to be able to
                     automatically find these two files. On Darwin systems it
if bHaveConfigBldDir:
         strConfigBldDir = vDictArgs["--cfgBldDir"]
     if (bHaveConfigBldDir == False) or (strConfigBldDir.__len__() == 0):
         strConfigBldDir = vstrFrameworkPythonDir
 
     return (bOk, strConfigBldDir, strErrMsg)
 
 #++---------------------------------------------------------------------------
 # Details:  Determine where to put the files. Retrieve the directory path for
-#           Python's dist_packages/ site_package folder on a Windows platform.
+#           Python's dist_packages / site_package folder when build for traditional
+#           unix layout.
 # Args:     vDictArgs   - (R) Program input parameters.
 # Returns:  Bool - True = function success, False = failure.
 #           Str - Python Framework directory path.
 #           strErrMsg - Error description on task failure.
 # Throws:   None.
 #--
 
 
-def get_framework_python_dir_windows(vDictArgs):
+def get_framework_python_dir_traditional(vDictArgs):
     dbg = utilsDebug.CDebugFnVerbose(
-        "Python script get_framework_python_dir_windows()")
+        "Python script get_framework_python_dir_traditional()")
     bOk = True
     strWkDir = ""
     strErrMsg = ""
 
+    dbg.dump_text("Built by LLVM")
     # We are being built by LLVM, so use the PYTHON_INSTALL_DIR argument,
     # and append the python version directory to the end of it.  Depending
     # on the system other stuff may need to be put here as well.
     from distutils.sysconfig import get_python_lib
     strPythonInstallDir = ""
     bHaveArgPrefix = "--prefix" in vDictArgs
     if bHaveArgPrefix:
         strPythonInstallDir = os.path.normpath(vDictArgs["--prefix"])
def get_framework_python_dir_traditional(vDictArgs):
     else:
         strWkDir = get_python_lib(True, False)
     strWkDir = os.path.normcase(os.path.join(strWkDir, "lldb"))
 
     return (bOk, strWkDir, strErrMsg)
 
 #++---------------------------------------------------------------------------
 # Details:  Retrieve the directory path for Python's dist_packages/
-#           site_package folder on a UNIX style platform.
+#           site_package folder for macos framework.
 # Args:     vDictArgs   - (R) Program input parameters.
 # Returns:  Bool - True = function success, False = failure.
 #           Str - Python Framework directory path.
 #           strErrMsg - Error description on task failure.
 # Throws:   None.
 #--
 
 
-def get_framework_python_dir_other_platforms(vDictArgs):
+def get_framework_python_dir_macos_framework(vDictArgs):
     dbg = utilsDebug.CDebugFnVerbose(
-        "Python script get_framework_python_dir_other_platform()")
+        "Python script get_framework_python_dir_macos_framework()")
     bOk = True
     strWkDir = ""
     strErrMsg = ""
     bDbg = "-d" in vDictArgs
 
-    bMakeFileCalled = "-m" in vDictArgs
-    if bMakeFileCalled:
-        dbg.dump_text("Built by LLVM")
-        return get_framework_python_dir_windows(vDictArgs)
-    else:
-        dbg.dump_text("Built by XCode")
-        # We are being built by XCode, so all the lldb Python files can go
-        # into the LLDB.framework/Resources/Python subdirectory.
-        strWkDir = vDictArgs["--targetDir"]
-        strWkDir = os.path.join(strWkDir, "LLDB.framework")
-        if os.path.exists(strWkDir):
-            if bDbg:
-                print((strMsgFoundLldbFrameWkDir % strWkDir))
-            strWkDir = os.path.join(strWkDir, "Resources", "Python", "lldb")
-            strWkDir = os.path.normcase(strWkDir)
-        else:
-            bOk = False
-            strErrMsg = strErrMsgFrameWkPyDirNotExist % strWkDir
 
     return (bOk, strWkDir, strErrMsg)
 
 #++---------------------------------------------------------------------------
 # Details:  Retrieve the directory path for Python's dist_packages/
 #           site_package folder depending on the type of OS platform being
 #           used.
 # Args:     vDictArgs   - (R) Program input parameters.
 # Returns:  Bool - True = function success, False = failure.
 #           Str - Python Framework directory path.
 #           strErrMsg - Error description on task failure.
 # Throws:   None.
 #--
 
 
 def get_framework_python_dir(vDictArgs):
     dbg = utilsDebug.CDebugFnVerbose(
         "Python script get_framework_python_dir()")
     bOk = True
     strWkDir = ""
     strErrMsg = ""
 
-    eOSType = utilsOsType.determine_os_type()
-    if eOSType == utilsOsType.EnumOsType.Unknown:
-        bOk = False
-        strErrMsg = strErrMsgOsTypeUnknown
-    elif eOSType == utilsOsType.EnumOsType.Windows:
-        bOk, strWkDir, strErrMsg = get_framework_python_dir_windows(vDictArgs)
+    bMakeFileCalled = "-m" in vDictArgs
+    if bMakeFileCalled:
+        return get_framework_python_dir_traditional(vDictArgs)
     else:
-        bOk, strWkDir, strErrMsg = get_framework_python_dir_other_platforms(
-            vDictArgs)
-
-    return (bOk, strWkDir, strErrMsg)
+        return get_framework_python_dir_macos_framework(vDictArgs)
 
 #++---------------------------------------------------------------------------
 # Details:  Retrieve the liblldb directory path, if it exists and is valid.
 # Args:     vDictArgs               - (R) Program input parameters.
 # Returns:  Bool - True = function success, False = failure.
 #           Str - liblldb directory path.
 #           strErrMsg - Error description on task failure.
 # Throws:   None.

lldb/scripts/finishSwigWrapperClasses.py

 """ Post process SWIG Bridge wrapper code Python script for Windows/LINUX/OSX platform
 
     --------------------------------------------------------------------------
     File:           finishSwigWrapperClasses.py
 
     Overview:       Python script(s) to finish off the SWIG Python C++ Script
                     Bridge wrapper code on the Windows/LINUX/OSX platform.
-                    The Python scripts are equivalent to the shell script (.sh)
-                    files.
                     We use SWIG to create a C++ file containing the appropriate
                     wrapper classes and functions for each scripting language,
                     before liblldb is built (thus the C++ file can be compiled
                     into liblldb.  In some cases, additional work may need to be
                     done after liblldb has been compiled, to make the scripting
                     language stuff fully functional.  Any such post-processing
                     is handled through the Python scripts called here.
 
def run_post_process_for_each_script_supported(vDictArgs):
     if not bOk:
         return (-8, strScriptDirNotFound)
 
     # Look for any script language directories to build for
     listDirs = ["Python"]
 
     # Iterate script directory find any script language directories
     for scriptLang in listDirs:
-        # __pycache__ is a magic directory in Python 3 that holds .pyc files
-        if scriptLang != "__pycache__" and scriptLang != "swig_bot_lib":
-            dbg.dump_text("Executing language script for \'%s\'" % scriptLang)
-            nResult, strStatusMsg = run_post_process(
-                scriptLang, strFinishFileName, vDictArgs)
         if nResult < 0:
             break
 
     if nResult < 0:
         strTmp = strPostProcessError % scriptLang
         strTmp += strStatusMsg
         strStatusMsg = strTmp