Install python dll to bin

[hhb]

Summary

Not sure whether this is a feature or bug...

[hhb]

Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above.

lldb/CMakeLists.txt

233

Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above..

[mstorsjo]

Sorry, I'm not familiar with how LLDB integrates with python and how all of that works on Windows, so I can't really comment on this one for now...

[labath]

Looking at the history goes provide us with some clues. It seems it was done to ensure that during development launching lldb uses the same python dll that the lldb was built with. However, this was done in the days when one had to build a custom python2 interpreter to build lldb on windows, and so version mismatches were much more likely. So, it's possible this is no longer needed (though I expect there will be at least one user somewhere which has grown a dependency on this somehow).

Anyway, I don't really have a horse in this race, but my instinct would be to say that lldb should not attempt to install python anywhere (just as we don't do that on non-windows platforms). There _might_ be a case for copying it to the build dir, if it increases developer comfort substantially, but ideally, I'd try to get rid of that too...

lldb/CMakeLists.txt

if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
         # When using the Visual Studio CMake generator the lldb binaries end up in Release/bin, Debug/bin etc.
         file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin" LLDB_BIN_DIR)
         file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
         add_custom_command(
             TARGET finish_swig
             POST_BUILD
             COMMAND ${CMAKE_COMMAND} -E copy ${PYTHON_DLL_NATIVE_PATH} ${LLDB_BIN_DIR} VERBATIM
             COMMENT "Copying Python DLL to LLDB binaries directory.")
+        get_filename_component(PYTHON_DLL_NAME ${PYTHON_DLL} NAME)
+        install(FILES ${LLDB_BIN_DIR}/${PYTHON_DLL_NAME} DESTINATION bin)
     endif ()
 endif ()
 
 if(LLDB_BUILT_STANDALONE AND NOT LLVM_ENABLE_IDE)
   llvm_distribution_add_targets()
 endif()