Page MenuHomePhabricator

Install python dll to bin
AbandonedPublic

Authored by hhb on Sep 23 2019, 5:40 PM.

Details

Reviewers
mstorsjo
Summary

Not sure whether this is a feature or bug...

Event Timeline

hhb created this revision.Sep 23 2019, 5:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 5:40 PM
hhb marked an inline comment as done.Sep 24 2019, 12:03 AM

Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above.

lldb/CMakeLists.txt
233

Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above..

Sorry, I'm not familiar with how LLDB integrates with python and how all of that works on Windows, so I can't really comment on this one for now...

labath added a subscriber: labath.Sep 24 2019, 1:01 AM

Looking at the history goes provide us with some clues. It seems it was done to ensure that during development launching lldb uses the same python dll that the lldb was built with. However, this was done in the days when one had to build a custom python2 interpreter to build lldb on windows, and so version mismatches were much more likely. So, it's possible this is no longer needed (though I expect there will be at least one user somewhere which has grown a dependency on this somehow).

Anyway, I don't really have a horse in this race, but my instinct would be to say that lldb should not attempt to install python anywhere (just as we don't do that on non-windows platforms). There _might_ be a case for copying it to the build dir, if it increases developer comfort substantially, but ideally, I'd try to get rid of that too...

hhb abandoned this revision.Sep 24 2019, 9:34 AM