Page MenuHomePhabricator

[MemorySSA] Update Phi insertion.
ClosedPublic

Authored by asbirlea on Sep 23 2019, 12:26 PM.

Details

Summary

MemoryPhis may be needed following a Def insertion inthe IDF of all the
new accesses added (phis + potentially a def). Ensure this also occurs when
only the new MemoryPhis are the defining accesses.

Note: The need for computing IDF here is because of new Phis added with
edges incoming from unreachable code, Phis that had previously been
simplified. The preferred solution is to not reintroduce such Phis.
This patch is the needed fix while working on the preferred solution.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea created this revision.Sep 23 2019, 12:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 12:26 PM
bjope added a subscriber: bjope.Sep 23 2019, 1:36 PM
asbirlea edited the summary of this revision. (Show Details)Sep 23 2019, 1:59 PM

LGTM, since this is a workaround to keep things rolling while we work on a more general fix.

Thanks!

This revision is now accepted and ready to land.Sep 23 2019, 3:23 PM
This revision was automatically updated to reflect the committed changes.