This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Rework a MinGW build fix from D65691
ClosedPublic

Authored by mstorsjo on Sep 22 2019, 12:15 PM.

Details

Summary

That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here, as long as the include uses lowercase windows.h (as is used consistently elsewhere in the llvm projects).

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 22 2019, 12:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2019, 12:15 PM

Let's wait for @hhb to give this a spin to avoid twiddling this back and forth.

hhb accepted this revision.Sep 23 2019, 11:00 AM

Thanks!

This revision is now accepted and ready to land.Sep 23 2019, 11:00 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 1:42 PM