This is an archive of the discontinued LLVM Phabricator instance.

Differential D67887

Use _WIN32 instead of _MSC_VER
ClosedPublic

Authored by hhb on Sep 21 2019, 6:18 PM.

Download Raw Diff

Details

Reviewers: None
Commits: rG5c82608d200e: Use _WIN32 instead of _MSC_VER
rL372493: Use _WIN32 instead of _MSC_VER
rLLDB372493: Use _WIN32 instead of _MSC_VER

Summary

This way it works better with MinGW.

Diff Detail

Repository

rG LLVM Github Monorepo

Build Status

Buildable 38400
Build 38399: arc lint + arc unit

Event Timeline

hhb created this revision.Sep 21 2019, 6:18 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2019, 6:18 PM

Herald added subscribers: lldb-commits, mstorsjo. · View Herald Transcript

Harbormaster completed remote builds in B38400: Diff 221206.Sep 21 2019, 6:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 21 2019, 6:19 PM

Closed by commit rL372493: Use _WIN32 instead of _MSC_VER (authored by hhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2019, 6:19 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Just FTR, this was identical to D67857 that I posted a few days ago.

mstorsjo mentioned this in D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target.Sep 22 2019, 11:08 AM

Revision Contents

Path

Size

lldb/

source/

Core/

2 lines

Diff 221206

lldb/source/Core/IOHandler.cpp

	Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
	#include "lldb/Target/StopInfo.h"			#include "lldb/Target/StopInfo.h"
	#include "lldb/Target/Target.h"			#include "lldb/Target/Target.h"
	#include "lldb/Target/Thread.h"			#include "lldb/Target/Thread.h"
	#include "lldb/Utility/State.h"			#include "lldb/Utility/State.h"
	#endif			#endif

	#include "llvm/ADT/StringRef.h"			#include "llvm/ADT/StringRef.h"

	#ifdef _MSC_VER			#ifdef _WIN32
	#include "lldb/Host/windows/windows.h"			#include "lldb/Host/windows/windows.h"
	#endif			#endif

	#include <memory>			#include <memory>
	#include <mutex>			#include <mutex>

	#include <assert.h>			#include <assert.h>
	#include <ctype.h>			#include <ctype.h>
	▲ Show 20 Lines • Show All 4,532 Lines • Show Last 20 Lines