Page MenuHomePhabricator

[Float2Int] avoid crashing on unreachable code (PR38502)
ClosedPublic

Authored by spatel on Sep 19 2019, 7:55 AM.

Details

Summary

In the example from:
https://bugs.llvm.org/show_bug.cgi?id=38502
...we hit infinite looping/crashing because we have non-standard IR - an instruction operand is used before defined.
This is allowed in unreachable blocks, so I'm proposing to avoid the problem by using DominatorTree to step around the landmines.

Diff Detail

Repository
rL LLVM

Event Timeline

spatel created this revision.Sep 19 2019, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2019, 7:55 AM
jmolloy accepted this revision.Sep 19 2019, 8:23 AM
This revision is now accepted and ready to land.Sep 19 2019, 8:23 AM
This revision was automatically updated to reflect the committed changes.