This is an archive of the discontinued LLVM Phabricator instance.

Differential D67759

[llvm-readobj] - Simplify stack-sizes.test test case.
ClosedPublic

Authored by grimar on Sep 19 2019, 5:14 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rG8ce581f586ba: [llvm-readobj] - Simplify stack-sizes.test test case.
rL372855: [llvm-readobj] - Simplify stack-sizes.test test case.
Summary

This is a follow-up for D67757,
which allows to describe .stack_sizes sections with a new
YAML syntax.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Sep 19 2019, 5:14 AM
Herald added subscribers: seiya, rupprecht. · View Herald TranscriptSep 19 2019, 5:14 AM
jhenderson accepted this revision.Sep 24 2019, 3:48 AM

LGTM.

This revision is now accepted and ready to land.Sep 24 2019, 3:48 AM
MaskRay accepted this revision.Sep 24 2019, 4:47 AM
grimar updated this revision to Diff 221545.Sep 24 2019, 7:55 AM
grimar retitled this revision from [llvm-readobj] - Simplify stack-sizes.test test case. to [llvm-readobj] - Support uniqued ".stack_sizes" and simplify stack-sizes.test test case..

I had to add a bit of code after rebasing this.
Problem is that when we have section names with a suffix, e.g. ".stack_sizes [1]",
we need to drop it, otherwise such name is not recognized properly and
section is not treated as special.

Can this be reviewed again, please?

grimar requested review of this revision.Sep 24 2019, 7:55 AM
jhenderson added a comment.Sep 25 2019, 2:07 AM

The latest changes look good themselves, but should this extra issue you've uncovered have a direct yaml2obj test?

grimar planned changes to this revision.Sep 25 2019, 2:14 AM
In D67759#1682095, @jhenderson wrote:

The latest changes look good themselves, but should this extra issue you've uncovered have a direct yaml2obj test?

Yeah, you're right. I should have posted 2 patches, one for yaml2obj and keep this one for llvm-readobj test case untouched.
seems things have mixed in my head. I'll split.

grimar updated this revision to Diff 221726.Sep 25 2019, 5:13 AM
grimar retitled this revision from [llvm-readobj] - Support uniqued ".stack_sizes" and simplify stack-sizes.test test case. to [llvm-readobj] - Simplify stack-sizes.test test case..
grimar edited the summary of this revision. (Show Details)

Now all code changes are gone and patch is in the same state as it was accepted.
Going to commit it.

grimar accepted this revision.Sep 25 2019, 5:13 AM
This revision is now accepted and ready to land.Sep 25 2019, 5:13 AM
grimar removed a reviewer: grimar.Sep 25 2019, 5:13 AM
This revision now requires review to proceed.Sep 25 2019, 5:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 5:16 AM
Closed by commit rL372855: [llvm-readobj] - Simplify stack-sizes.test test case. (authored by grimar). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 5:16 AM

Revision Contents

PathSize
llvm/
trunk/
test/
tools/
llvm-readobj/
30 lines

Diff 221727

llvm/trunk/test/tools/llvm-readobj/stack-sizes.test

Show All 38 Lines - Name: .text
Flags: [SHF_ALLOC] Flags: [SHF_ALLOC]
Size: 16 Size: 16
- Name: .text.baz - Name: .text.baz
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [SHF_ALLOC] Flags: [SHF_ALLOC]
Size: 16 Size: 16
- Name: .stack_sizes - Name: .stack_sizes
Type: SHT_PROGBITS Type: SHT_PROGBITS
## 2 stack size entries. Each consists of an address (subject to relocation) Entries:
## followed by a ULEB for the size. - Size: 0x10
Content: "000000000000000010000000000000000020" - Size: 0x20
Link: .text Link: .text
- Name: '.stack_sizes [1]' - Name: '.stack_sizes [1]'
Type: SHT_PROGBITS Type: SHT_PROGBITS
## One stack size entry. Entries:
Content: "200000000000000008" - Address: 0x20
Size: 0x8
Link: .text.baz Link: .text.baz
- Name: .rela.stack_sizes - Name: .rela.stack_sizes
Type: SHT_RELA Type: SHT_RELA
Info: .stack_sizes Info: .stack_sizes
Relocations: Relocations:
## A symbol relative reference. ## A symbol relative reference.
- Offset: 0 - Offset: 0
Symbol: referenced_by_symbol_foo Symbol: referenced_by_symbol_foo
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 LinesFileHeader:
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .text - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [SHF_ALLOC] Flags: [SHF_ALLOC]
Size: 16 Size: 16
- Name: .stack_sizes - Name: .stack_sizes
Type: SHT_PROGBITS Type: SHT_PROGBITS
Content: "100000000000000010200000000000000020" Entries:
- Address: 0x10
Size: 0x10
- Address: 0x20
Size: 0x20
Link: .text Link: .text
Symbols: Symbols:
- Name: foo - Name: foo
Section: .text Section: .text
Value: 0x10 Value: 0x10
Type: STT_FUNC Type: STT_FUNC
Binding: STB_GLOBAL Binding: STB_GLOBAL
- Name: bar - Name: bar
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Size: 8 Size: 8
- Name: .text2 - Name: .text2
Type: SHT_PROGBITS Type: SHT_PROGBITS
Size: 8 Size: 8
Flags: [SHF_ALLOC] Flags: [SHF_ALLOC]
- Name: .stack_sizes - Name: .stack_sizes
Type: SHT_PROGBITS Type: SHT_PROGBITS
Content: "000000000000000008" Entries:
- Size: 0x8
Link: .text2 Link: .text2
- Name: .rela.stack_sizes - Name: .rela.stack_sizes
Type: SHT_RELA Type: SHT_RELA
Info: .stack_sizes Info: .stack_sizes
Relocations: Relocations:
- Offset: 0 - Offset: 0
Symbol: foo Symbol: foo
Type: R_X86_64_64 Type: R_X86_64_64
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 LinesFileHeader:
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .text - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Size: 8 Size: 8
- Name: .stack_sizes - Name: .stack_sizes
Type: SHT_PROGBITS Type: SHT_PROGBITS
Link: .text Link: .text
Content: "000000000000000008" Entries:
- Size: 0x8
- Name: .rela.stack_sizes - Name: .rela.stack_sizes
Type: SHT_RELA Type: SHT_RELA
Info: .stack_sizes Info: .stack_sizes
Relocations: Relocations:
- Offset: 0 - Offset: 0
Symbol: foo Symbol: foo
Type: R_X86_64_64 Type: R_X86_64_64
Symbols: Symbols:
Show All 28 LinesFileHeader:
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .text - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Size: 8 Size: 8
- Name: .stack_sizes - Name: .stack_sizes
Type: SHT_PROGBITS Type: SHT_PROGBITS
Link: .text Link: .text
Content: "000000000000000008" Entries:
- Size: 0x1
## Check that we handle multiple object files, separately and when they ## Check that we handle multiple object files, separately and when they
## are in an archive. This also checks whether we have blank lines between the ## are in an archive. This also checks whether we have blank lines between the
## tables. ## tables.
# RUN: llvm-ar rc %t1.a %t01 %t02 # RUN: llvm-ar rc %t1.a %t01 %t02
# RUN: llvm-readelf --stack-sizes %t01 %t02 \ # RUN: llvm-readelf --stack-sizes %t01 %t02 \
# RUN: | FileCheck %s --check-prefixes=MULTIPLE-GNU,OBJECT -DFILE1=%t01 -DFILE2=%t02 # RUN: | FileCheck %s --check-prefixes=MULTIPLE-GNU,OBJECT -DFILE1=%t01 -DFILE2=%t02
▲ Show 20 Lines • Show All 199 Lines • ▼ Show 20 LinesFileHeader:
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .text - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [SHF_ALLOC] Flags: [SHF_ALLOC]
Size: 16 Size: 16
- Name: .stack_sizes - Name: .stack_sizes
Type: SHT_PROGBITS Type: SHT_PROGBITS
Content: "100000000000000010" Entries:
- Address: 0x10
Size: 0x10
Link: .text Link: .text
Symbols: Symbols:
- Name: _Z3foof - Name: _Z3foof
Section: .text Section: .text
Value: 0x10 Value: 0x10
Type: STT_FUNC Type: STT_FUNC
Binding: STB_GLOBAL Binding: STB_GLOBAL
Show All 25 Lines