[ScriptInterpreter] Initialize globals when loading a scripting module.

[JDevlieghere]

Summary

The LoadScriptingModule used by command script import wasn't initializing the LLDB global variables (things like lldb.frame and lldb.debugger). They would get initialized however when running the interactive script interpreter or running a single script line (e.g. script print(lldb.frame)). This patch fixes that by properly initializing the globals when loading a Python module.

[davide]

LGTM

[MaskRay]

lldb/lit/Commands/Inputs/frame.py

3 ↗

(On Diff #220415)

No newline at end of file

lldb/trunk/lit/Commands/Inputs/frame.py

+import lldb
+print(lldb.frame)

lldb/trunk/lit/Commands/command-script-import.test

+# RUN: echo 'b main' > %t.in
+# RUN: echo 'run' >> %t.in
+# RUN: echo 'command script import %S/Inputs/frame.py' >> %t.in
+
+# RUN: %clang -g -O0 %S/../Settings/Inputs/main.c -o %t.out
+# RUN: %lldb -b -s %t.in %t.out | FileCheck %s
+
+# CHECK: frame #0

lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

bool ScriptInterpreterPythonImpl::LoadScriptingModule(
   {
     FileSpec target_file(pathname);
     FileSystem::Instance().Resolve(target_file);
     std::string basename(target_file.GetFilename().GetCString());
 
     StreamString command_stream;
 
     // Before executing Python code, lock the GIL.
-    Locker py_lock(this,
-                   Locker::AcquireLock |
-                       (init_session ? Locker::InitSession : 0) |
-                       Locker::NoSTDIN,
-                   Locker::FreeAcquiredLock |
-                       (init_session ? Locker::TearDownSession : 0));
+    Locker py_lock(
+        this,
+        Locker::AcquireLock | (init_session ? Locker::InitSession : 0) |
+            (init_session ? Locker::InitGlobals : 0) | Locker::NoSTDIN,
     namespace fs = llvm::sys::fs;
     fs::file_status st;
     std::error_code ec = status(target_file.GetPath(), st);
 
     if (ec || st.type() == fs::file_type::status_error ||
         st.type() == fs::file_type::type_unknown ||
         st.type() == fs::file_type::file_not_found) {
       // if not a valid file of any sort, check if it might be a filename still