This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Refactor the code.
ClosedPublic

Authored by grimar on Sep 16 2019, 8:32 AM.

Details

Summary

It's a straightforward refactoring that allows to simplify and encapsulate the code.

Diff Detail

Event Timeline

grimar created this revision.Sep 16 2019, 8:32 AM
grimar updated this revision to Diff 220348.Sep 16 2019, 8:35 AM
  • Now with context.
MaskRay accepted this revision.Sep 16 2019, 9:04 AM
This revision is now accepted and ready to land.Sep 16 2019, 9:04 AM

I`ll remove NFC from title. It prints a <?> as a name instead of nothing when error occurs.
(But these cases were never tested yet anyways.)

grimar retitled this revision from [llvm-readobj] - Refactor the code. NFC. to [llvm-readobj] - Refactor the code..Sep 17 2019, 1:50 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 17 2019, 1:52 AM