This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] Create helper struct for handling analysis getters
ClosedPublic

Authored by uenoku on Sep 15 2019, 8:44 PM.

Details

Summary

This patch introduces a helper struct AnalysisGetter to put together analysis getters. In this patch, a getter for AAResult is also added for noalias.

Diff Detail

Event Timeline

uenoku created this revision.Sep 15 2019, 8:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
uenoku edited the summary of this revision. (Show Details)
jdoerfert added inline comments.Sep 15 2019, 10:24 PM
llvm/lib/Transforms/IPO/Attributor.cpp
4105–4106

Can we move this stuff into the AnalysisGetter as well? e.g., only pass the FAM or even the module manager AM?

uenoku updated this revision to Diff 220284.Sep 16 2019, 12:54 AM

Pass FAM to AnalysisGetter.

jdoerfert accepted this revision.Sep 16 2019, 4:44 AM

I like this version a lot better, thx. LGTM.

This revision is now accepted and ready to land.Sep 16 2019, 4:44 AM
This revision was automatically updated to reflect the committed changes.