This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Python 3 support: Update type comparisons and type names
ClosedPublic

Authored by hubert.reinterpretcast on Sep 14 2019, 9:42 AM.

Details

Summary

This patch is split out from D67535, updating type names (or in one case type(1.4)-style goodness) and updating type comparisons with use of isinstance. Additionally, changed a dictionary key lookup for a type mapping.

As requested by reviewers in D67535, spaces are added after commas in what are now tuples of types.

Event Timeline

  • Add spaces around operators on lines touched

Thanks for this massive cleanup. LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 15 2019, 4:00 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2019, 4:00 PM