This is an archive of the discontinued LLVM Phabricator instance.

[LICM] Don't verify domtree/loopinfo unless EXPENSIVE_CHECKS is enabled.
ClosedPublic

Authored by efriedma on Sep 13 2019, 2:22 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

efriedma created this revision.Sep 13 2019, 2:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2019, 2:22 PM
Herald added a subscriber: asbirlea. · View Herald Transcript
fhahn accepted this revision.Sep 13 2019, 3:09 PM

Thanks Eli, LGTM. This is in line with how we handle verification in many other places.

For EXPENSIVE_CHECKS, we also enable verify-loop-info & verify-dom-info, but I think it is worth keeping the extra verification here, as plenty of things could go wrong in LICM after this point, before we are done.

This revision is now accepted and ready to land.Sep 13 2019, 3:09 PM
This revision was automatically updated to reflect the committed changes.