Page MenuHomePhabricator

[GlobalISel] Fix insertion point of new instructions to be after PHIs
ClosedPublic

Authored by aemerson on Sep 13 2019, 2:13 PM.

Details

Summary

For some reason we sometimes insert new instructions one instruction before the first non-PHI when legalizing. This can result in having non-PHI instructions before PHIs, which mean that PHI elimination doesn't catch them.

Diff Detail

Repository
rL LLVM

Event Timeline

aemerson created this revision.Sep 13 2019, 2:13 PM
volkan accepted this revision.Sep 13 2019, 2:15 PM
volkan added a reviewer: volkan.

LGTM.

This revision is now accepted and ready to land.Sep 13 2019, 2:15 PM
This revision was automatically updated to reflect the committed changes.