Page MenuHomePhabricator

[MemorySSA] Pass (for update) MSSAU when hoisting instructions.
ClosedPublic

Authored by asbirlea on Sep 11 2019, 2:57 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea created this revision.Sep 11 2019, 2:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2019, 2:57 PM

Thanks for this!

Just a general style nit, and LGTM

lib/Transforms/Scalar/LoopUnswitch.cpp
424 ↗(On Diff #219816)

nit: generally unique_ptr<T>& is only used when you want to update what the unique_ptr itself is pointing to. if you just want to use *MSSAU from the function, please pass it as a MemorySSAUpdater & (or MemorySSAUpdater * if it's potentially null)

506 ↗(On Diff #219816)

same nit

This revision is now accepted and ready to land.Sep 11 2019, 4:57 PM
asbirlea updated this revision to Diff 219947.Sep 12 2019, 10:10 AM

Thank you for the suggestion and review.

This revision was automatically updated to reflect the committed changes.