This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] Rename SHOffset (e_shoff) field to SHOff. NFC
ClosedPublic

Authored by MaskRay on Sep 5 2019, 10:23 PM.

Details

Summary

struct Elf*_Shdr has a field sh_offset, named ShOffset in
llvm::ELFYAML::Section. Rename SHOffset (e_shoff) to SHOff to prevent confusion.

Diff Detail

Event Timeline

MaskRay created this revision.Sep 5 2019, 10:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2019, 10:23 PM
MaskRay updated this revision to Diff 219027.Sep 5 2019, 10:27 PM

Fix test/Object/invalid.test and a reference in a comment

grimar accepted this revision.Sep 6 2019, 1:44 AM

LGTM

This revision is now accepted and ready to land.Sep 6 2019, 1:44 AM
grimar added a comment.Sep 6 2019, 1:45 AM

nit: I'd add "NFC" to title.

MaskRay updated this revision to Diff 219049.Sep 6 2019, 2:16 AM
MaskRay retitled this revision from [yaml2obj] Rename SHOffset (e_shoff) field to SHOff to [yaml2obj] Rename SHOffset (e_shoff) field to SHOff. NFC.
MaskRay edited the summary of this revision. (Show Details)

Add NFC to the title

This revision was automatically updated to reflect the committed changes.

Um... Why was this marked NFC? It changed one of the tags...

grimar added a comment.Sep 6 2019, 5:34 AM

Oh indeed... I did not notice it changed the tag too. It is my fault, I asked for this.