This is an archive of the discontinued LLVM Phabricator instance.

[Object] remove struct constructor, NFC
ClosedPublic

Authored by cishida on Sep 5 2019, 5:56 PM.

Reviewers

avl
dblaikie

Commits

Summary

make POD struct by removing ctors

Repository

rG LLVM Github Monorepo

Build Status

Buildable 37819
Build 37818: arc lint + arc unit

Sounds good to me - thanks!

This revision is now accepted and ready to land.Sep 5 2019, 7:14 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

include/

llvm/

Object/

5 lines

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines	public:
}		}
section_iterator getRelocatedSection() const;		section_iterator getRelocatedSection() const;

DataRefImpl getRawDataRefImpl() const;		DataRefImpl getRawDataRefImpl() const;
const ObjectFile *getObject() const;		const ObjectFile *getObject() const;
};		};

struct SectionedAddress {		struct SectionedAddress {
// TODO: constructors could be removed when C++14 would be adopted.
SectionedAddress() {}
SectionedAddress(uint64_t Addr, uint64_t SectIdx)
: Address(Addr), SectionIndex(SectIdx) {}

const static uint64_t UndefSection = UINT64_MAX;		const static uint64_t UndefSection = UINT64_MAX;

uint64_t Address = 0;		uint64_t Address = 0;
uint64_t SectionIndex = UndefSection;		uint64_t SectionIndex = UndefSection;
};		};

inline bool operator<(const SectionedAddress &LHS,		inline bool operator<(const SectionedAddress &LHS,
const SectionedAddress &RHS) {		const SectionedAddress &RHS) {
▲ Show 20 Lines • Show All 430 Lines • Show Last 20 Lines