Page MenuHomePhabricator

DWARF: Fix a regression in location list dumping
ClosedPublic

Authored by labath on Sep 3 2019, 8:13 AM.

Details

Summary

While fixing the handling of some error cases, r370363 introduced new
problems -- assertion failures due to unchecked errors (my excuse is that a very
early version of that patch used Optional<T> instead of Expected).

This patch adds proper handling of parsing errors encountered when
dumping location lists from inside DWARF DIEs, and adds a bunch of
additional tests.

I reorder the arguments of the location list dumping functions to make
them consistent, and also be able to dump the two kinds of location
lists generically.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Sep 3 2019, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2019, 8:13 AM
Herald added a subscriber: aprantl. · View Herald Transcript
This revision is now accepted and ready to land.Sep 3 2019, 9:29 AM
This revision was automatically updated to reflect the committed changes.