Page MenuHomePhabricator

compiler-rt/builtins: Make check-builtins run tests on macOS.

Authored by thakis on Aug 29 2019, 5:19 PM.

Diff Detail


Event Timeline

thakis created this revision.Aug 29 2019, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 5:19 PM

delcypher, kubamracek : ping.

delcypher, kubamracek: Would you prefer if someone else looked at this?

@thakis This looks like a reasonable start but I'd like to test this before landing it. @arphaman might have opinions too.

The approach seems reasonable to me

What's the next step here?

I think @delcypher wanted to test it first

smaller diff

@thakis Sorry for the delay on this. I should have some time this afternoon to try this out.

@thakis I gave this patch a try. It seems to work apart from the i386 tests that will not work on macOS Catalina. We can deal with that later though.

I've never looked at the builtins before. There are some very weird things about the tests here that don't make any sense to me but that's not part of this patch so I won't dwell on them here.

delcypher accepted this revision.Sep 13 2019, 5:29 PM
This revision is now accepted and ready to land.Sep 13 2019, 5:29 PM
This revision was automatically updated to reflect the committed changes.