This is an archive of the discontinued LLVM Phabricator instance.

llvm/docs/DeveloperPolicy.rst
415	Needs "cd trunk/" before svn commit, otherwise ~/TMP/tmp-llvm-svn$ svn commit -m " ... " svn: E155007: '/home/xbolva00/TMP/tmp-llvm-svn' is not a working copy

Fix svn commit instructions.

Harbormaster completed remote builds in B38773: Diff 222508.Sep 30 2019, 3:47 PM

I am not able to run the last step successfully. Initially, I thought it's because I used wrong password. So I sent another new password hash to Chris Lattner to update it. He updated the password hash for me. When I used the new password to run svn commit -m "Request commit access for jtony" still failed. Anyway know why? Thanks!

I think this would be useful to have in?

llvm/docs/DeveloperPolicy.rst
415	ping?

xbolva00 added inline comments.Oct 9 2019, 11:12 PM

llvm/docs/DeveloperPolicy.rst
415	ping what?

mehdi_amini added inline comments.Oct 10 2019, 12:00 AM

llvm/docs/DeveloperPolicy.rst
415	Nevermind, it seems it has been fixed already. I probably had an old diff I was looking at, since I hit the same issue locally.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2019, 4:36 PM

Closed by commit rG97578b14fca6: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access (authored by tstellar). · Explain Why

This revision was automatically updated to reflect the committed changes.

In D66840#1702109, @jtony wrote:

I am not able to run the last step successfully. Initially, I thought it's because I used wrong password. So I sent another new password hash to Chris Lattner to update it. He updated the password hash for me. When I used the new password to run svn commit -m "Request commit access for jtony" still failed. Anyway know why? Thanks!

Anyone run into similar issue? What should I do? Thanks!

In D66840#1702109, @jtony wrote:

I am not able to run the last step successfully. Initially, I thought it's because I used wrong password. So I sent another new password hash to Chris Lattner to update it. He updated the password hash for me. When I used the new password to run svn commit -m "Request commit access for jtony" still failed. Anyway know why? Thanks!

Problem solved, by explicitly specify username and password when commiting (not wait until prompt the password enter)

svn commit -m "Request commit access for jtony" --username=jtony --password=$PASSWORD
Sending        github-usernames.txt
Transmitting file data .
Committed revision 375223.

Revision Contents

Path

Size

llvm/

docs/

DeveloperPolicy.rst

20 lines

Diff 222508

llvm/docs/DeveloperPolicy.rst

	Show First 20 Lines • Show All 390 Lines • ▼ Show 20 Lines

	In any case, your changes are still subject to `code review`_ (either before or			In any case, your changes are still subject to `code review`_ (either before or
	after they are committed, depending on the nature of the change). You are			after they are committed, depending on the nature of the change). You are
	encouraged to review other peoples' patches as well, but you aren't required			encouraged to review other peoples' patches as well, but you aren't required
	to do so.			to do so.

	.. _discuss the change/gather consensus:			.. _discuss the change/gather consensus:

				Obtaining Commit Access to the GitHub Repository
				------------------------------------------------
				We are currently in the process of migrating the project's source code from SVN
				to a git repository on GitHub. We are maintaining a file in SVN to map
				SVN usernames to GitHub usernames, so we can automatically grant access to
				existing committers when we complete the migration to GitHub. In order to
				request commit access, check out the github-usernames.txt file in meta/trunk and
				add a line in the form of $SVN_USERNAME:$GITHUB_USERNAME and commit it. For
				example:

				.. code:: console

				mkdir tmp-llvm-svn
				cd tmp-llvm-svn
				svn co https://$SVN_USERNAME@llvm.org/svn/llvm-project/meta/trunk
				echo "$SVN_USERNAME:$GITHUB_USERNAME" >> trunk/github-usernames.txt
				cd trunk
				xbolva00Unsubmitted Not Done Reply Inline Actions Needs "cd trunk/" before svn commit, otherwise ~/TMP/tmp-llvm-svn$ svn commit -m " ... " svn: E155007: '/home/xbolva00/TMP/tmp-llvm-svn' is not a working copy xbolva00: Needs "cd trunk/" before svn commit, otherwise ~/TMP/tmp-llvm-svn$ svn commit -m " ... " svn…
				mehdi_aminiUnsubmitted Not Done Reply Inline Actions ping? mehdi_amini: ping?
				xbolva00Unsubmitted Not Done Reply Inline Actions ping what? xbolva00: ping what?
				mehdi_aminiUnsubmitted Not Done Reply Inline Actions Nevermind, it seems it has been fixed already. I probably had an old diff I was looking at, since I hit the same issue locally. mehdi_amini: Nevermind, it seems it has been fixed already. I probably had an old diff I was looking at…
				svn commit -m "Request commit access for $SVN_USERNAME"


	Making a Major Change			Making a Major Change
	---------------------			---------------------

	When a developer begins a major new project with the aim of contributing it back			When a developer begins a major new project with the aim of contributing it back
	to LLVM, they should inform the community with an email to the `llvm-dev			to LLVM, they should inform the community with an email to the `llvm-dev
	<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ email list, to the extent			<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ email list, to the extent
	possible. The reason for this is to:			possible. The reason for this is to:

	▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

docs/DeveloperPolicy: Add instructions for requesting GitHub commit accessClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 222508

llvm/docs/DeveloperPolicy.rst

docs/DeveloperPolicy: Add instructions for requesting GitHub commit access
ClosedPublic