Page MenuHomePhabricator

docs/DeveloperPolicy: Add instructions for requesting GitHub commit access
ClosedPublic

Authored by tstellar on Aug 27 2019, 3:56 PM.

Diff Detail

Event Timeline

tstellar created this revision.Aug 27 2019, 3:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2019, 3:56 PM
xbolva00 added inline comments.
llvm/docs/DeveloperPolicy.rst
415

Needs "cd trunk/" before svn commit, otherwise

~/TMP/tmp-llvm-svn$ svn commit -m " ... "
svn: E155007: '/home/xbolva00/TMP/tmp-llvm-svn' is not a working copy

tstellar updated this revision to Diff 222508.Mon, Sep 30, 3:47 PM

Fix svn commit instructions.

jtony added a subscriber: jtony.Wed, Oct 9, 1:00 PM

I am not able to run the last step successfully. Initially, I thought it's because I used wrong password. So I sent another new password hash to Chris Lattner to update it. He updated the password hash for me. When I used the new password to run svn commit -m "Request commit access for jtony" still failed. Anyway know why? Thanks!

I think this would be useful to have in?

llvm/docs/DeveloperPolicy.rst
415

ping?

xbolva00 added inline comments.Wed, Oct 9, 11:12 PM
llvm/docs/DeveloperPolicy.rst
415

ping what?

mehdi_amini added inline comments.Thu, Oct 10, 12:00 AM
llvm/docs/DeveloperPolicy.rst
415

Nevermind, it seems it has been fixed already. I probably had an old diff I was looking at, since I hit the same issue locally.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Oct 10, 4:36 PM
This revision was automatically updated to reflect the committed changes.

I am not able to run the last step successfully. Initially, I thought it's because I used wrong password. So I sent another new password hash to Chris Lattner to update it. He updated the password hash for me. When I used the new password to run svn commit -m "Request commit access for jtony" still failed. Anyway know why? Thanks!

Anyone run into similar issue? What should I do? Thanks!

jtony added a comment.EditedFri, Oct 18, 4:57 AM

I am not able to run the last step successfully. Initially, I thought it's because I used wrong password. So I sent another new password hash to Chris Lattner to update it. He updated the password hash for me. When I used the new password to run svn commit -m "Request commit access for jtony" still failed. Anyway know why? Thanks!

Problem solved, by explicitly specify username and password when commiting (not wait until prompt the password enter)

svn commit -m "Request commit access for jtony" --username=jtony --password=$PASSWORD
Sending        github-usernames.txt
Transmitting file data .
Committed revision 375223.