This is an archive of the discontinued LLVM Phabricator instance.

Differential D66756

compiler-rt: use more __sanitizer_time_t on FreeBSD
ClosedPublic

Authored by emaste on Aug 26 2019, 10:37 AM.

Details

Reviewers
dim
devnexen
Commits
rCRT370755: compiler-rt: use more __sanitizer_time_t on FreeBSD
rG14cf2b20ca6d: compiler-rt: use more __sanitizer_time_t on FreeBSD
rL370755: compiler-rt: use more __sanitizer_time_t on FreeBSD
Summary

A few structs were using long for time_t members. No functional change.

Diff Detail

Event Timeline

emaste created this revision.Aug 26 2019, 10:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2019, 10:37 AM
Herald added a subscriber: dberris. · View Herald Transcript
devnexen added a comment.Aug 27 2019, 12:14 AM
This comment was removed by devnexen.
compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_freebsd.h
117

Would 'SANITIZER_WORDSIZE' be more appropriate ?

devnexen added a comment.Aug 27 2019, 12:14 AM
This comment was removed by devnexen.
devnexen accepted this revision.Aug 28 2019, 8:59 PM
This revision is now accepted and ready to land.Aug 28 2019, 8:59 PM
emaste added a comment.Aug 29 2019, 5:20 AM

It turns out __LP64__ is wrong anyway, see D66758, so I intend to commit this first with no functional change and then follow up with D66758.

Closed by commit rL370755: compiler-rt: use more __sanitizer_time_t on FreeBSD (authored by emaste). · Explain WhySep 3 2019, 6:40 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptSep 3 2019, 6:40 AM

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
22 lines

Diff 217195

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_freebsd.h

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines struct __sanitizer_ipc_perm {
unsigned int cgid; unsigned int cgid;
unsigned int uid; unsigned int uid;
unsigned int gid; unsigned int gid;
unsigned short mode; unsigned short mode;
unsigned short seq; unsigned short seq;
long key; long key;
}; };
#if defined(__LP64___)
devnexenUnsubmitted
Not Done
ReplyInline Actions

Would 'SANITIZER_WORDSIZE' be more appropriate ?

devnexen: Would 'SANITIZER_WORDSIZE' be more appropriate ?
typedef long long __sanitizer_time_t;
#else
typedef long __sanitizer_time_t;
#endif
struct __sanitizer_shmid_ds { struct __sanitizer_shmid_ds {
__sanitizer_ipc_perm shm_perm; __sanitizer_ipc_perm shm_perm;
unsigned long shm_segsz; unsigned long shm_segsz;
unsigned int shm_lpid; unsigned int shm_lpid;
unsigned int shm_cpid; unsigned int shm_cpid;
int shm_nattch; int shm_nattch;
unsigned long shm_atime; __sanitizer_time_t shm_atime;
unsigned long shm_dtime; __sanitizer_time_t shm_dtime;
unsigned long shm_ctime; __sanitizer_time_t shm_ctime;
}; };
extern unsigned struct_msqid_ds_sz; extern unsigned struct_msqid_ds_sz;
extern unsigned struct_mq_attr_sz; extern unsigned struct_mq_attr_sz;
extern unsigned struct_timeb_sz; extern unsigned struct_timeb_sz;
extern unsigned struct_statvfs_sz; extern unsigned struct_statvfs_sz;
struct __sanitizer_iovec { struct __sanitizer_iovec {
Show All 14 Lines# undef ifa_dstaddr
typedef unsigned __sanitizer_pthread_key_t; typedef unsigned __sanitizer_pthread_key_t;
struct __sanitizer_passwd { struct __sanitizer_passwd {
char *pw_name; char *pw_name;
char *pw_passwd; char *pw_passwd;
int pw_uid; int pw_uid;
int pw_gid; int pw_gid;
long pw_change; __sanitizer_time_t pw_change;
char *pw_class; char *pw_class;
char *pw_gecos; char *pw_gecos;
char *pw_dir; char *pw_dir;
char *pw_shell; char *pw_shell;
long pw_expire; __sanitizer_time_t pw_expire;
int pw_fields; int pw_fields;
}; };
struct __sanitizer_group { struct __sanitizer_group {
char *gr_name; char *gr_name;
char *gr_passwd; char *gr_passwd;
int gr_gid; int gr_gid;
char **gr_mem; char **gr_mem;
}; };
#if defined(__LP64___)
typedef long long __sanitizer_time_t;
#else
typedef long __sanitizer_time_t;
#endif
typedef long __sanitizer_suseconds_t; typedef long __sanitizer_suseconds_t;
struct __sanitizer_timeval { struct __sanitizer_timeval {
__sanitizer_time_t tv_sec; __sanitizer_time_t tv_sec;
__sanitizer_suseconds_t tv_usec; __sanitizer_suseconds_t tv_usec;
}; };
struct __sanitizer_itimerval { struct __sanitizer_itimerval {
▲ Show 20 Lines • Show All 471 Lines • Show Last 20 Lines