This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Don't emit google-runtime-references warning for functions defined in macros.
ClosedPublic

Authored by hokein on Aug 23 2019, 1:11 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Aug 23 2019, 1:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2019, 1:12 AM
Herald added a subscriber: xazax.hun. · View Herald Transcript
gribozavr accepted this revision.Aug 23 2019, 1:21 AM

LGTM, although I'd be more comfortable with a whitelist of macros.

clang-tools-extra/test/clang-tidy/google-runtime-references.cpp
156 ↗(On Diff #216775)

Please add back the newline.

This revision is now accepted and ready to land.Aug 23 2019, 1:21 AM
hokein updated this revision to Diff 216777.Aug 23 2019, 1:45 AM
hokein marked an inline comment as done.

Add the missing back newline.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2019, 1:49 AM