[sanitizer] Update symbolizer/scripts

[sugak]

Summary

Running build_symbolizer.sh on the latest master exits with error reporting missing symbol: _ZN4llvm5MachO13TextAPIReader3getENS_15MemoryBufferRefE.
Updated build_symbolizer.sh to use libLLVMTextAPI.a that provides the missing symbol.

With the above, missing isspace is reported, add it to the global_symbols.txt

[twoh]

Hello @vitalybuka, I'm trying to land it on behalf of @sugak, but if I run arc patch it keeps failing with

Checking patch lib/sanitizer_common/symbolizer/scripts/global_symbols.txt...
error: lib/sanitizer_common/symbolizer/scripts/global_symbols.txt: does not exist in index
Checking patch lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh...
error: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh: does not exist in index

 Patch Failed!
Usage Exception: Unable to apply patch!

Is there anything I need to do differently for this patch? Thanks!

[sugak]

Could that be due to the fact that I made this change from compiler-rt.git and not the monorepo?

lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

cmake -GNinja \
     -DCMAKE_CXX_FLAGS_RELEASE="${LLVM_FLAGS}" \
     -DLLVM_TABLEGEN=$TBLGEN \
     -DLLVM_ENABLE_ZLIB=ON \
     -DLLVM_ENABLE_TERMINFO=OFF \
     -DLLVM_ENABLE_THREADS=OFF \
   $LLVM_SRC
 fi
 cd ${LLVM_BUILD}
-ninja LLVMSymbolize LLVMObject LLVMBinaryFormat LLVMDebugInfoDWARF LLVMSupport LLVMDebugInfoPDB LLVMMC LLVMDemangle
+ninja LLVMSymbolize LLVMObject LLVMBinaryFormat LLVMDebugInfoDWARF LLVMSupport LLVMDebugInfoPDB LLVMMC LLVMDemangle LLVMTextAPI
 
 cd ${BUILD_DIR}
 rm -rf ${SYMBOLIZER_BUILD}
 mkdir ${SYMBOLIZER_BUILD}
 cd ${SYMBOLIZER_BUILD}
 
 echo "Compiling..."
 SYMBOLIZER_FLAGS="$LLVM_FLAGS -I${LLVM_SRC}/include -I${LLVM_BUILD}/include -std=c++14"
 $CXX $SYMBOLIZER_FLAGS ${SRC_DIR}/sanitizer_symbolize.cpp ${SRC_DIR}/sanitizer_wrappers.cpp -c
 $AR rc symbolizer.a sanitizer_symbolize.o sanitizer_wrappers.o
 
 SYMBOLIZER_API_LIST=__sanitizer_symbolize_code,__sanitizer_symbolize_data,__sanitizer_symbolize_flush,__sanitizer_symbolize_demangle
 
 # Merge all the object files together and copy the resulting library back.
 $SCRIPT_DIR/ar_to_bc.sh $LIBCXX_BUILD/lib/libc++.a \
                         $LIBCXX_BUILD/lib/libc++abi.a \
                         $LLVM_BUILD/lib/libLLVMSymbolize.a \
                         $LLVM_BUILD/lib/libLLVMObject.a \
                         $LLVM_BUILD/lib/libLLVMBinaryFormat.a \
                         $LLVM_BUILD/lib/libLLVMDebugInfoDWARF.a \
                         $LLVM_BUILD/lib/libLLVMSupport.a \
                         $LLVM_BUILD/lib/libLLVMDebugInfoPDB.a \
                         $LLVM_BUILD/lib/libLLVMDemangle.a \
                         $LLVM_BUILD/lib/libLLVMMC.a \
+                        $LLVM_BUILD/lib/libLLVMTextAPI.a \
                         $ZLIB_BUILD/libz.a \
                         symbolizer.a \
                         all.bc
 
 echo "Optimizing..."
 $OPT -internalize -internalize-public-api-list=${SYMBOLIZER_API_LIST} all.bc -o opt.bc
 $CC $FLAGS -fno-lto -c opt.bc -o symbolizer.o
 

lib/sanitizer_common/symbolizer/scripts/global_symbols.txt

 getpagesize U
 getpid U
 getrlimit U
 gettimeofday U
 ioctl U
 isalpha U
 isatty U
 islower U
+isspace U
 isprint U
 isupper U
 isxdigit U
 log10 U
 lseek U
 lseek64 U
 malloc U
 mbrlen U