Page MenuHomePhabricator

twoh (Taewook Oh)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2016, 3:03 PM (241 w, 2 d)

Recent Activity

Nov 27 2019

twoh added a comment to D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Sorry my bad. Seems that some powerpc tests are failing. Will revert soon and take a look.

Nov 27 2019, 11:13 AM · Restricted Project
taewookoh <taewook.oh@gmail.com> committed rGb19ec1eb3d0c: [BPI] Improve unreachable/ColdCall heurstics to handle loops. (authored by twoh).
[BPI] Improve unreachable/ColdCall heurstics to handle loops.
Nov 27 2019, 10:37 AM
twoh closed D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..
Nov 27 2019, 10:36 AM · Restricted Project
twoh updated the diff for D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Rebase

Nov 27 2019, 9:41 AM · Restricted Project

Nov 25 2019

twoh updated the diff for D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Rebase

Nov 25 2019, 8:52 AM · Restricted Project

Nov 20 2019

twoh updated the diff for D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Addressing comments from @skatkov. Thank you for your review!

Nov 20 2019, 10:48 AM · Restricted Project

Nov 19 2019

twoh added inline comments to D45890: [OMPT] Add implementation and tests of Archer tool.
Nov 19 2019, 2:33 PM · Restricted Project
twoh added a comment to D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Friendly ping. @chandlerc @skatkov Can you please suggest other reviewers if you're too busy to review? Thanks!

Nov 19 2019, 2:24 PM · Restricted Project

Nov 18 2019

twoh updated the diff for D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Rebase

Nov 18 2019, 10:05 AM · Restricted Project

Nov 14 2019

twoh updated the diff for D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Rebase

Nov 14 2019, 9:11 AM · Restricted Project

Nov 11 2019

twoh updated the diff for D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..

Add "CHECK" for the test.

Nov 11 2019, 4:55 PM · Restricted Project
twoh created D70104: [BPI] Improve unreachable/ColdCall heurstics to handle loops..
Nov 11 2019, 4:55 PM · Restricted Project

Sep 4 2019

twoh committed rG1975e635e643: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs (authored by twoh).
[IRPrinting] Improve module pass printer to work better with -filter-print-funcs
Sep 4 2019, 1:11 AM
twoh committed rL370849: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs.
[IRPrinting] Improve module pass printer to work better with -filter-print-funcs
Sep 4 2019, 1:08 AM
twoh closed D66560: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs.
Sep 4 2019, 1:08 AM · Restricted Project

Sep 3 2019

twoh added a comment to D66560: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs.

Friendly ping!

Sep 3 2019, 1:28 PM · Restricted Project

Aug 28 2019

twoh added a reviewer for D66560: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs: philip.pfaffe.
Aug 28 2019, 11:33 AM · Restricted Project

Aug 27 2019

twoh added a comment to D66560: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs.

Friendly ping!

Aug 27 2019, 10:46 AM · Restricted Project

Aug 23 2019

twoh updated the diff for D66560: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs.

Rebase

Aug 23 2019, 9:04 AM · Restricted Project

Aug 22 2019

twoh committed rGe03f34dd0969: [sanitizer] Resubmit D66620 from monorepo (authored by twoh).
[sanitizer] Resubmit D66620 from monorepo
Aug 22 2019, 4:35 PM
twoh committed rL369716: [sanitizer] Resubmit D66620 from monorepo.
[sanitizer] Resubmit D66620 from monorepo
Aug 22 2019, 4:34 PM
twoh closed D66624: [sanitizer] Resubmit D66620 from monorepo.
Aug 22 2019, 4:34 PM · Restricted Project, Restricted Project
twoh created D66624: [sanitizer] Resubmit D66620 from monorepo.
Aug 22 2019, 4:30 PM · Restricted Project, Restricted Project
twoh added a comment to D66620: [sanitizer] Update symbolizer/scripts.

Hello @vitalybuka, I'm trying to land it on behalf of @sugak, but if I run arc patch it keeps failing with

Checking patch lib/sanitizer_common/symbolizer/scripts/global_symbols.txt...
error: lib/sanitizer_common/symbolizer/scripts/global_symbols.txt: does not exist in index
Checking patch lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh...
error: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh: does not exist in index
Aug 22 2019, 4:03 PM · Restricted Project, Restricted Project

Aug 21 2019

twoh created D66560: [IRPrinting] Improve module pass printer to work better with -filter-print-funcs.
Aug 21 2019, 2:52 PM · Restricted Project

Aug 15 2019

twoh committed rG213d8a9f1389: [NewPM][PassInstrumentation] IR printing support for (Thin)LTO (authored by twoh).
[NewPM][PassInstrumentation] IR printing support for (Thin)LTO
Aug 15 2019, 10:49 AM
twoh committed rL369024: [NewPM][PassInstrumentation] IR printing support for (Thin)LTO.
[NewPM][PassInstrumentation] IR printing support for (Thin)LTO
Aug 15 2019, 10:48 AM
twoh closed D66253: [NewPM][PassInstrumentation] IR printing support for (Thin)LTO.
Aug 15 2019, 10:48 AM · Restricted Project
twoh updated the diff for D66253: [NewPM][PassInstrumentation] IR printing support for (Thin)LTO.

Remove redundant lines from the test.

Aug 15 2019, 10:17 AM · Restricted Project
twoh updated the diff for D66253: [NewPM][PassInstrumentation] IR printing support for (Thin)LTO.

Addressed @tejohnson's comment on the test case. Thanks!

Aug 15 2019, 10:17 AM · Restricted Project

Aug 14 2019

twoh created D66253: [NewPM][PassInstrumentation] IR printing support for (Thin)LTO.
Aug 14 2019, 1:28 PM · Restricted Project
twoh committed rGdf7022825c0e: [DebugInfo] Consider debug label scope has an extra lexical block file (authored by twoh).
[DebugInfo] Consider debug label scope has an extra lexical block file
Aug 14 2019, 11:01 AM
twoh committed rL368891: [DebugInfo] Consider debug label scope has an extra lexical block file.
[DebugInfo] Consider debug label scope has an extra lexical block file
Aug 14 2019, 10:58 AM
twoh closed D66187: [DebugInfo] Consider debug label scope has an extra lexical block file.
Aug 14 2019, 10:58 AM · debug-info, Restricted Project
twoh committed rGd4c50f7326a0: [NewPM][PassInstrumentation] IR printing support from clang driver (authored by twoh).
[NewPM][PassInstrumentation] IR printing support from clang driver
Aug 14 2019, 12:12 AM
twoh committed rL368804: [NewPM][PassInstrumentation] IR printing support from clang driver.
[NewPM][PassInstrumentation] IR printing support from clang driver
Aug 14 2019, 12:12 AM
twoh closed D65975: [NewPM][PassInstrumentation] IR printing support from clang driver.
Aug 14 2019, 12:12 AM · Restricted Project, Restricted Project

Aug 13 2019

twoh added a comment to D66187: [DebugInfo] Consider debug label scope has an extra lexical block file.

@dblaikie Thank you for the comment. I encountered this problem while manipulating LLVM IR, and not sure how realistic the code can be if I synthesize one to reproduce this problem. Still, I think this is worth fixing unless we can guarantee that debug label scope won't have a DILexicalBlockFile.

Aug 13 2019, 6:19 PM · debug-info, Restricted Project
twoh created D66187: [DebugInfo] Consider debug label scope has an extra lexical block file.
Aug 13 2019, 4:30 PM · debug-info, Restricted Project
twoh added a comment to D65975: [NewPM][PassInstrumentation] IR printing support from clang driver.

@fedor.sergeev Sorry for the late reply. I missed your comment.

Aug 13 2019, 9:26 AM · Restricted Project, Restricted Project
twoh updated the diff for D65975: [NewPM][PassInstrumentation] IR printing support from clang driver.

Avoid -O2 from the test.

Aug 13 2019, 9:24 AM · Restricted Project, Restricted Project

Aug 9 2019

twoh committed rG6c99bb2d9a42: Revert the test commit (authored by twoh).
Revert the test commit
Aug 9 2019, 1:54 PM
twoh committed rL368485: Revert the test commit.
Revert the test commit
Aug 9 2019, 1:54 PM
twoh committed rG20ead38653f0: Test commit. (authored by twoh).
Test commit.
Aug 9 2019, 1:50 PM
twoh committed rL368483: Test commit..
Test commit.
Aug 9 2019, 1:50 PM

Aug 8 2019

twoh added a comment to D65975: [NewPM][PassInstrumentation] IR printing support from clang driver.

@fedor.sergeev @yamauchi I saw your discussions over llvm-dev mailing list regarding IR printing with the new pass manager, and though this might be the reason why IR printing is not supported under new PM with clang. I would appreciate if you can take a look.

Aug 8 2019, 2:27 PM · Restricted Project, Restricted Project
twoh created D65975: [NewPM][PassInstrumentation] IR printing support from clang driver.
Aug 8 2019, 2:26 PM · Restricted Project, Restricted Project

Aug 6 2019

twoh abandoned D65816: [libcxx] Mark unsupported tests under root user.

@ldionne Got it. Thank you for your explanation!

Aug 6 2019, 11:51 AM · Restricted Project
twoh added a comment to D65816: [libcxx] Mark unsupported tests under root user.

I explained it over libcxx-dev mailing list, but our internal build system requires root permission when running the build and test from the remote container. I admit that this is not a common case, but still, wouldn't it be better to make the tests working under any circumstance?

Aug 6 2019, 11:40 AM · Restricted Project
twoh created D65816: [libcxx] Mark unsupported tests under root user.
Aug 6 2019, 10:14 AM · Restricted Project

Jun 19 2019

twoh added a comment to rL336869: IR: Skip -print-*-all after -print-*.

@dexonsmith Thank you for your reply. Are you considering the case where -print-after-all is used along with -print-* pass? If so, shouldn't we have -print-module explicitly in the test case?

Jun 19 2019, 10:39 AM

Jun 18 2019

twoh added a comment to rL336869: IR: Skip -print-*-all after -print-*.

Hello, can you please explain a bit more about this change? What kind of redundant outputs avoided by this? Thanks!

Jun 18 2019, 11:25 PM

Jun 5 2019

twoh added a comment to D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on.

@Hahnfeld Got it. Then it seems that there's not much we can do here :(

Jun 5 2019, 1:00 AM · Restricted Project

Jun 4 2019

twoh added a comment to D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on.

@Hahnfeld I'm not an OpenMP expert and don't have much strong argument here, but IMHO it might be confusing to have LLVM_ENABLE_FFI and LIBOMPTARGET_ENABLE_FFI have different default value from user's perspective. I wonder if we can set it off by default and explicitly turn it on for builds with test?

Jun 4 2019, 11:33 PM · Restricted Project
twoh updated the diff for D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on.

@grokos Thanks for the suggestion. What about this?

Jun 4 2019, 10:32 PM · Restricted Project

Jun 3 2019

twoh updated the diff for D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on.

Addressed comments from @Hahnfeld. Thanks!

Jun 3 2019, 11:47 PM · Restricted Project
twoh created D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on.
Jun 3 2019, 11:18 PM · Restricted Project

May 15 2019

twoh committed rG9d020de3e867: [PredicateInfo] Do not process unreachable operands. (authored by twoh).
[PredicateInfo] Do not process unreachable operands.
May 15 2019, 12:35 PM
twoh committed rL360796: [PredicateInfo] Do not process unreachable operands..
[PredicateInfo] Do not process unreachable operands.
May 15 2019, 12:35 PM
twoh closed D61154: [PredicateInfo] Do not process unreachable operands..
May 15 2019, 12:35 PM · Restricted Project
twoh updated the diff for D61154: [PredicateInfo] Do not process unreachable operands..

Use isReachableFromEntry. Thank you for the suggestion!

May 15 2019, 12:23 PM · Restricted Project
twoh updated the diff for D61154: [PredicateInfo] Do not process unreachable operands..

Thank you for your comments @efriedma! I addressed your comments and added a test case. The test segfaults clang without proposed change.

May 15 2019, 11:22 AM · Restricted Project

May 14 2019

twoh added a comment to D61154: [PredicateInfo] Do not process unreachable operands..

Friendly ping again. This is a fix for a compiler crash.

May 14 2019, 11:50 AM · Restricted Project

May 3 2019

twoh added a comment to D61154: [PredicateInfo] Do not process unreachable operands..

Friendly ping. Thanks!

May 3 2019, 9:43 AM · Restricted Project

Apr 30 2019

twoh added a comment to D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used.

Friendly ping for comments. Thanks!

Apr 30 2019, 8:43 AM · Restricted Project

Apr 29 2019

twoh added inline comments to D61282: [InlineCost] Check if caller formulates indirect recursion..
Apr 29 2019, 3:55 PM · Restricted Project
twoh created D61282: [InlineCost] Check if caller formulates indirect recursion..
Apr 29 2019, 2:35 PM · Restricted Project

Apr 25 2019

twoh created D61154: [PredicateInfo] Do not process unreachable operands..
Apr 25 2019, 2:32 PM · Restricted Project

Apr 22 2019

Herald added a project to D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used: Restricted Project.

Hello @rsmith, @wenlei and I took another look at this, and we couldn't find any use of AnonymousTagLocations outside of debug info. If that's actually the case, wouldn't it make sense to have DebugColumnInfo to control the field even if AnonymousTagLocations the part of generic printing policy?

Apr 22 2019, 10:23 AM · Restricted Project

Apr 3 2019

twoh committed rGa960f8996288: [ProfileSummary] Count callsite samples when computing total samples. (authored by twoh).
[ProfileSummary] Count callsite samples when computing total samples.
Apr 3 2019, 12:57 PM
twoh committed rL357627: [ProfileSummary] Count callsite samples when computing total samples..
[ProfileSummary] Count callsite samples when computing total samples.
Apr 3 2019, 12:53 PM
twoh closed D59835: [ProfileSummary] Count callsite samples when computing total samples..
Apr 3 2019, 12:53 PM · Restricted Project

Apr 2 2019

twoh added a comment to D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..

@wmi Thank you for the concrete example! I think what we need for your example is context-sensitive profiling and function specialization, not inlining. Admittedly we don't have an infrastructure in LLVM to support context-sensitive profiling for non-inlined case and we don't perform context sensitive function specialization...

Apr 2 2019, 4:00 PM · Restricted Project
twoh added a comment to D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..

@wmi Thank you for the detailed explanation!

Apr 2 2019, 12:04 PM · Restricted Project
twoh added a comment to D59835: [ProfileSummary] Count callsite samples when computing total samples..

@wmi Thanks for taking a look! Performance numbers were neutral from our side.

Apr 2 2019, 10:50 AM · Restricted Project
twoh committed rG6a27c48be223: [SampleProfile] Repeat indirect call promotion only when the target is actually… (authored by twoh).
[SampleProfile] Repeat indirect call promotion only when the target is actually…
Apr 2 2019, 8:47 AM
twoh committed rL357484: [SampleProfile] Repeat indirect call promotion only when the target is actually….
[SampleProfile] Repeat indirect call promotion only when the target is actually…
Apr 2 2019, 8:46 AM
twoh closed D59940: [SampleProfile] Repeat indirect call promotion only when the target is actually hot..
Apr 2 2019, 8:46 AM · Restricted Project

Apr 1 2019

twoh updated the diff for D59940: [SampleProfile] Repeat indirect call promotion only when the target is actually hot..

Check for the new pass manager added. Thanks @wmi for the comment!

Apr 1 2019, 11:34 PM · Restricted Project
twoh added a comment to D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..

@wmi Thanks for the reply! I can totally understand that entry count is not as precise as total count, but still don't think current implementation is the right way to address the issue. As I mentioned in the summary it compares two different things (instruction level counter vs function level counter), opens up a possibility for optimizing against wrong function (e.g. long and cold function), and makes it hard to find the root cause of the performance issue.

Apr 1 2019, 5:06 PM · Restricted Project
twoh created D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..
Apr 1 2019, 11:55 AM · Restricted Project

Mar 28 2019

twoh updated the diff for D59940: [SampleProfile] Repeat indirect call promotion only when the target is actually hot..

Remove unnecessary metadata.

Mar 28 2019, 8:51 AM · Restricted Project
twoh created D59940: [SampleProfile] Repeat indirect call promotion only when the target is actually hot..
Mar 28 2019, 8:48 AM · Restricted Project

Mar 26 2019

twoh created D59835: [ProfileSummary] Count callsite samples when computing total samples..
Mar 26 2019, 12:21 PM · Restricted Project

Feb 8 2019

twoh committed rOMP353538: Guard a feature that unsupported by old GCC.
Guard a feature that unsupported by old GCC
Feb 8 2019, 9:17 AM
twoh committed rG91c32fd8c8fa: Guard a feature that unsupported by old GCC (authored by twoh).
Guard a feature that unsupported by old GCC
Feb 8 2019, 9:16 AM
twoh committed rL353538: Guard a feature that unsupported by old GCC.
Guard a feature that unsupported by old GCC
Feb 8 2019, 9:16 AM
twoh closed D57851: Guard a feature that unsupported by old GCC.
Feb 8 2019, 9:16 AM · Restricted Project, Restricted Project

Feb 7 2019

twoh updated the diff for D57851: Guard a feature that unsupported by old GCC.

Addressing comments from @Hahnfeld. Thanks!

Feb 7 2019, 11:59 PM · Restricted Project, Restricted Project

Feb 6 2019

twoh added a comment to D57851: Guard a feature that unsupported by old GCC.

@kkwli0 Thanks for letting me know! But wouldn't https://reviews.llvm.org/D57848 always fall to "else" case added if the compiler is not GCC?

Feb 6 2019, 3:12 PM · Restricted Project, Restricted Project
twoh created D57851: Guard a feature that unsupported by old GCC.
Feb 6 2019, 2:47 PM · Restricted Project, Restricted Project

Feb 4 2019

twoh accepted D57537: Adjust cardinality of internal inliner thresholds.

LGTM

Feb 4 2019, 8:52 AM · Restricted Project

Jan 9 2019

twoh added a comment to D56505: expand DIContext interface a bit.

Can you please provide a bit more context about when the client might want this function?

Jan 9 2019, 10:56 AM
twoh accepted D56499: refactor BlockFrequencyInfo::view to take a title parameter.

LGTM

Jan 9 2019, 10:51 AM

Nov 5 2018

twoh committed rL346151: [MergeICmps] Do not perform the transformation if GEP is used outside of block.
[MergeICmps] Do not perform the transformation if GEP is used outside of block
Nov 5 2018, 10:19 AM
twoh closed D54089: [MergeICmps] Do not perform the transformation if GEP is used outside of block.
Nov 5 2018, 10:19 AM
twoh updated the diff for D54089: [MergeICmps] Do not perform the transformation if GEP is used outside of block.

Comments for the test updated. Thanks for the comment!

Nov 5 2018, 10:13 AM
twoh added a comment to D53911: [Orc] make getResponsibilitySetWithLegacyFn behavior match with LegacyJITSymbolResolver::getResponsibilitySet.

Friendly ping. Thanks!

Nov 5 2018, 8:59 AM · Restricted Project

Nov 4 2018

twoh created D54089: [MergeICmps] Do not perform the transformation if GEP is used outside of block.
Nov 4 2018, 9:36 PM

Oct 30 2018

twoh added a comment to D53860: [SemaCXX] Don't check base's dtor is accessible.

@rsmith I see. Thank you for the clarification!

Oct 30 2018, 6:48 PM