Page MenuHomePhabricator

[sanitizer] Update symbolizer/scripts
ClosedPublic

Authored by sugak on Thu, Aug 22, 2:16 PM.

Details

Summary

Running build_symbolizer.sh on the latest master exits with error reporting missing symbol: _ZN4llvm5MachO13TextAPIReader3getENS_15MemoryBufferRefE.
Updated build_symbolizer.sh to use libLLVMTextAPI.a that provides the missing symbol.

With the above, missing isspace is reported, add it to the global_symbols.txt

Diff Detail

Event Timeline

sugak created this revision.Thu, Aug 22, 2:16 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptThu, Aug 22, 2:16 PM
Herald added subscribers: Restricted Project, llvm-commits. · View Herald Transcript
vitalybuka accepted this revision.Thu, Aug 22, 3:30 PM
This revision is now accepted and ready to land.Thu, Aug 22, 3:30 PM
twoh added a subscriber: twoh.Thu, Aug 22, 4:01 PM

Hello @vitalybuka, I'm trying to land it on behalf of @sugak, but if I run arc patch it keeps failing with

Checking patch lib/sanitizer_common/symbolizer/scripts/global_symbols.txt...
error: lib/sanitizer_common/symbolizer/scripts/global_symbols.txt: does not exist in index
Checking patch lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh...
error: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh: does not exist in index

 Patch Failed!
Usage Exception: Unable to apply patch!

Is there anything I need to do differently for this patch? Thanks!

sugak added a comment.Thu, Aug 22, 4:13 PM

Could that be due to the fact that I made this change from compiler-rt.git and not the monorepo?

vitalybuka edited the summary of this revision. (Show Details)Thu, Aug 22, 5:55 PM
vitalybuka closed this revision.Thu, Aug 22, 5:58 PM
vitalybuka edited the summary of this revision. (Show Details)