[analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

[chris.laplante]

Summary

Current code assumes flags in CompilerLinkerOptionMap don't use =.

[chris.laplante]

I encountered this issue when trying to integrate scan-build with CMake in a cross-compiling environment.

[chris.laplante]

Ping?

[NoQ]

Thanks!!

I wish i had time to fix D55683 so that i could have you write tests for it :)

[chris.laplante]

In D66569#1658413, @NoQ wrote:

I wish i had time to fix D55683 so that i could have you write tests for it :)

I just subscribed to it, so if/when you do, I'll add some tests :)

[NoQ]

You don't have commit access, right? Do you want me to commit this patch for you?

[chris.laplante]

Correct, no access so please commit for me. This is my first contribution.

clang/tools/scan-build/libexec/ccc-analyzer

 my %DisabledArchs = ('ppc' => 1, 'ppc64' => 1);
 my %ArchsSeen;
 my $HadArch = 0;
 my $HasSDK = 0;
 
 # Process the arguments.
 foreach (my $i = 0; $i < scalar(@ARGV); ++$i) {
   my $Arg = $ARGV[$i];
-  my ($ArgKey) = split /=/,$Arg,2;
+  my @ArgParts = split /=/,$Arg,2;
+  my $ArgKey = @ArgParts[0];
 
   # Be friendly to "" in the argument list.
   if (!defined($ArgKey)) {
     next;
   }
 
   # Modes ccc-analyzer supports
   if ($Arg =~ /^-(E|MM?)$/) { $Action = 'preprocess'; }
if ($UniqueOptions{$Arg}) {
         next;
       }
       $Uniqued{$Arg} = 1;
     }
 
     push @CompileOpts,$Arg;
     push @LinkOpts,$Arg;
 
+    if (scalar @ArgParts == 1) {
       while ($Cnt > 0) {
         ++$i; --$Cnt;
         push @CompileOpts, $ARGV[$i];
         push @LinkOpts, $ARGV[$i];
       }
+    }
     next;
   }
 
   # Ignored options.
   if (defined $IgnoredOptionMap{$ArgKey}) {
     my $Cnt = $IgnoredOptionMap{$ArgKey};
     while ($Cnt > 0) {
       ++$i; --$Cnt;