This is an archive of the discontinued LLVM Phabricator instance.

Differential D66523

[LLD][ELF] - Simplify the bad-archive.s test case.
ClosedPublic

Authored by grimar on Aug 21 2019, 3:47 AM.

Details

Reviewers
ruiu
MaskRay
psmith
• espindola
Commits
rGa50f115d3673: [LLD][ELF] - Simplify the bad-archive.s test case.
rLLD369516: [LLD][ELF] - Simplify the bad-archive.s test case.
rL369516: [LLD][ELF] - Simplify the bad-archive.s test case.
Summary

This removes the precompiled binary and improves the
check of the error reported.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Aug 21 2019, 3:47 AM
Herald added a reviewer: • espindola. · View Herald TranscriptAug 21 2019, 3:47 AM
Herald added subscribers: arichardson, emaste. · View Herald Transcript
MaskRay accepted this revision.Aug 21 2019, 4:10 AM
This revision is now accepted and ready to land.Aug 21 2019, 4:10 AM
peter.smith added a subscriber: peter.smith.Aug 21 2019, 4:15 AM

LGTM too.

Closed by commit rL369516: [LLD][ELF] - Simplify the bad-archive.s test case. (authored by grimar). · Explain WhyAug 21 2019, 4:23 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2019, 4:23 AM

Revision Contents

PathSize
lld/
trunk/
test/
ELF/
Inputs/
2 lines
9 lines

Diff 216369

lld/trunk/test/ELF/Inputs/bad-archive.a

!<arch>
this is malformed archive used in bad-archive.s

lld/trunk/test/ELF/bad-archive.s

// REQUIRES: x86 // REQUIRES: x86
// Check bad archive error reporting with --whole-archive // Check bad archive error reporting with --whole-archive
// and without it. // and without it.
// RUN: echo "!<arch>" > %t.a
// RUN: echo "foo" >> %t.a
// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o // RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
// RUN: not ld.lld %t.o %p/Inputs/bad-archive.a -o %t 2>&1 | FileCheck %s // RUN: not ld.lld %t.o %t.a -o %t 2>&1 | FileCheck -DFILE=%t.a %s
// RUN: not ld.lld %t.o --whole-archive %p/Inputs/bad-archive.a -o %t 2>&1 | FileCheck %s // RUN: not ld.lld %t.o --whole-archive %t.a -o %t 2>&1 | FileCheck -DFILE=%t.a %s
// CHECK: bad-archive.a: failed to parse archive // CHECK: error: [[FILE]]: failed to parse archive: truncated or malformed archive (remaining size of archive too small for next archive member header at offset 8)
.globl _start .globl _start
_start: _start: