Page MenuHomePhabricator

[LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC)
ClosedPublic

Authored by mib on Aug 20 2019, 2:43 PM.

Details

Summary

The test for conditional breakpoints on Windows was skipped because
there was no expression evaluation support at the time it was written.

After removing the annotation and testing it again, the test is passing.
http://lists.llvm.org/pipermail/lldb-dev/2019-August/015405.html

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Repository
rL LLVM

Event Timeline

mib created this revision.Aug 20 2019, 2:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2019, 2:43 PM
stella.stamenova accepted this revision.Aug 20 2019, 2:50 PM

LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though.

This revision is now accepted and ready to land.Aug 20 2019, 2:50 PM
mib added a comment.Aug 20 2019, 2:56 PM

LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though.

Will do!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2019, 2:58 PM