This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Codesign test executables if necessary

Authored by vsk on Aug 20 2019, 1:57 PM.

Diff Detail

Event Timeline

vsk created this revision.Aug 20 2019, 1:57 PM
vsk updated this revision to Diff 216243.Aug 20 2019, 1:58 PM
  • Attach a diff with context.
vsk updated this revision to Diff 216298.Aug 20 2019, 5:47 PM
  • Teach '%run' about code signing.
  • Introduce to handle code signing in commands like 'not %run …'. A '%run' substitution that includes the codesign command cannot achieve the same thing.
ldionne added inline comments.Aug 29 2019, 7:28 AM
12 ↗(On Diff #216298)

Note to self and other reviewers: I checked and I don't think you missed this change in any other test -- all the other .sh.cpp tests already use %run.


Just to be sure there's no subtle interaction I'm missing -- this is an entirely separate change packed into this patch, correct?

40 ↗(On Diff #216298)

Why don't we instead use sys.argv[2:], and avoid the funny delete argv[0] calls above?

vsk marked 2 inline comments as done.Aug 29 2019, 10:20 AM
vsk added inline comments.

Yes. I can split this out into a separate patch if it helps. It occurred to me that this was a problem when I wrote ", env={})" in, so I thought I'd fix it everywhere in one shot.

40 ↗(On Diff #216298)

Sounds good. I'll update the style in as a follow-up.

vsk updated this revision to Diff 217935.Aug 29 2019, 10:32 AM
  • Address coding style issue in
ldionne accepted this revision.Sep 5 2019, 2:10 PM
This revision is now accepted and ready to land.Sep 5 2019, 2:10 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2019, 2:23 PM