Explicitly Cast Constants to DWORD

[jmittert]

Summary

STATUS_SINGLE_STEP and STATUS_BREAKPOINT are defined as 0x8------ which
is negative and thus can't be implicitly narrowed to a DWORD which is
unsigned.

[amccarth]

Is this necessary? I see

C++
#define STATUS_BREAKPOINT                ((DWORD   )0x80000003L)
#define STATUS_SINGLE_STEP               ((DWORD   )0x80000004L)

in C:\Program Files (x86)\Windows Kits\8.1\Include\um\winnt.h

[jmittert]

I believe it's using the one in ntstatus.h

10.0.16299.0\shared\ntstatus.h
#define STATUS_BREAKPOINT                ((NTSTATUS)0x80000003L)    // winnt

And NTSTATUS is defined as a LONG in powerbase.h

10.0.16299.0\um\powerbase.h
#define NTSTATUS LONG

which would make it a signed (negative) number.

[compnerd]

SVN r369788

source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp

NativeProcessWindows::OnDebugException(bool first_chance,
 
   static bool initial_stop = false;
   if (!first_chance) {
     SetState(eStateStopped, false);
   }
 
   ExceptionResult result = ExceptionResult::SendToApplication;
   switch (record.GetExceptionCode()) {
-  case STATUS_SINGLE_STEP:
+  case DWORD(STATUS_SINGLE_STEP):
   case STATUS_WX86_SINGLE_STEP:
     StopThread(record.GetThreadID(), StopReason::eStopReasonTrace);
     SetState(eStateStopped, true);
 
     // Continue the debugger.
     return ExceptionResult::MaskException;
 
-  case STATUS_BREAKPOINT:
+  case DWORD(STATUS_BREAKPOINT):
   case STATUS_WX86_BREAKPOINT:
     if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
       LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.",
                record.GetExceptionAddress());
 
       StopThread(record.GetThreadID(), StopReason::eStopReasonBreakpoint);
 
       if (NativeThreadWindows *stop_thread =