Page MenuHomePhabricator

[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
ClosedPublic

Authored by hubert.reinterpretcast on Aug 19 2019, 2:20 PM.

Details

Summary

rL367756 (f5c40cb) increases the dependency of LLVMOrcJIT on LLVMPasses. In particular, symbols defined in LLVMPasses that are referenced by the destructor of PassBuilder are now referenced by LLVMOrcJIT through Speculation.cpp.o.

We believe that referencing symbols defined in LLVMPasses in the destructor of PassBuilder is valid, and that adding to the set of such symbols is legitimate. To support such cases, this patch adds LLVMPasses to the set of libraries being linked when linking in LLVMOrcJIT causes such symbols from LLVMPasses to be referenced.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2019, 2:20 PM
Herald added a subscriber: mgorny. · View Herald Transcript

I already has a patch for this, but it is still in review because of unrelated stuff to this issue. So please go head and commit this.

Thanks for this patch.

pree-jackie accepted this revision.Aug 19 2019, 3:02 PM
This revision is now accepted and ready to land.Aug 19 2019, 3:02 PM
This revision was automatically updated to reflect the committed changes.