This is an archive of the discontinued LLVM Phabricator instance.

Differential D66441

[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
ClosedPublic

Authored by hubert.reinterpretcast on Aug 19 2019, 2:20 PM.

Details

Reviewers
Whitney
anhtuyen
pree-jackie
Commits
rG1b8425cf6f83: Merging r369310: --------------------------------------------------------------…
rL371042: Merging r369310:
rG71974b517550: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
rL369310: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
Summary

rL367756 (f5c40cb) increases the dependency of LLVMOrcJIT on LLVMPasses. In particular, symbols defined in LLVMPasses that are referenced by the destructor of PassBuilder are now referenced by LLVMOrcJIT through Speculation.cpp.o.

We believe that referencing symbols defined in LLVMPasses in the destructor of PassBuilder is valid, and that adding to the set of such symbols is legitimate. To support such cases, this patch adds LLVMPasses to the set of libraries being linked when linking in LLVMOrcJIT causes such symbols from LLVMPasses to be referenced.

Diff Detail

Repository
rL LLVM

Event Timeline

hubert.reinterpretcast created this revision.Aug 19 2019, 2:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2019, 2:20 PM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B36975: Diff 215984.Aug 19 2019, 2:21 PM
pree-jackie added a comment.Aug 19 2019, 3:01 PM

I already has a patch for this, but it is still in review because of unrelated stuff to this issue. So please go head and commit this.

Thanks for this patch.

pree-jackie accepted this revision.Aug 19 2019, 3:02 PM
This revision is now accepted and ready to land.Aug 19 2019, 3:02 PM
Closed by commit rL369310: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC (authored by hubert.reinterpretcast). · Explain WhyAug 19 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
ExecutionEngine/
Orc/
1 line
tools/
lli/
1 line
unittests/
ExecutionEngine/
Orc/
1 line

Diff 216017

llvm/trunk/lib/ExecutionEngine/Orc/CMakeLists.txt

Show All 29 Linesadd_llvm_library(LLVMOrcJIT
intrinsics_gen intrinsics_gen
) )
target_link_libraries(LLVMOrcJIT target_link_libraries(LLVMOrcJIT
PRIVATE PRIVATE
LLVMAnalysis LLVMAnalysis
LLVMBitReader LLVMBitReader
LLVMBitWriter LLVMBitWriter
LLVMPasses
) )

llvm/trunk/tools/lli/CMakeLists.txt

if ( LLVM_INCLUDE_UTILS ) if ( LLVM_INCLUDE_UTILS )
add_subdirectory(ChildTarget) add_subdirectory(ChildTarget)
endif() endif()
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
CodeGen CodeGen
Core Core
ExecutionEngine ExecutionEngine
IRReader IRReader
Interpreter Interpreter
MC MC
MCJIT MCJIT
Object Object
OrcJIT OrcJIT
Passes
RuntimeDyld RuntimeDyld
SelectionDAG SelectionDAG
Support Support
Target Target
TransformUtils TransformUtils
native native
) )
Show All 32 Lines

llvm/trunk/unittests/ExecutionEngine/Orc/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Core Core
ExecutionEngine ExecutionEngine
Object Object
OrcJIT OrcJIT
Passes
RuntimeDyld RuntimeDyld
Support Support
native native
) )
add_llvm_unittest(OrcJITTests add_llvm_unittest(OrcJITTests
CoreAPIsTest.cpp CoreAPIsTest.cpp
IndirectionUtilsTest.cpp IndirectionUtilsTest.cpp
Show All 21 Lines