- User Since
- Nov 8 2018, 8:35 AM (86 w, 3 d)
Tue, Jun 9
Sun, Jun 7
Thank you very much Ayal for your suggestion. I adjusted the file accordingly.
Hello Ayal @Ayal , when you have some time, can you review this patch to the testcases, please! Thank you very much!
May 22 2020
May 19 2020
Extend pr45679-fold-tail-by-masking.ll with an additional RUN of -force-vector-width=1 and -force-vector-interleave=4 from https://reviews.llvm.org/D80085.
I write to ask if there is any thing else in this patch you like me to address. If not, please see if you could approve it. A number of testcases I am running are affected and it will be great if I can get them pass with this patch. Thank you very much!
May 17 2020
LGTM , too. Thanks for extending this feature.
May 16 2020
Similar to the 2nd patch earlier, this patch includes all the changes recommended by the reviewers.
- modified the 2nd function of the LIT test to make it clearer and simpler, and
- added ORE to confirm which pass has/does not have the impact.
This patch includes all the changes recommended by the reviewers - thank you very much!
I also added a new LIT test, which uses the ORE to confirm which pass has the impact.
In terms of testing, I have run a number of test-cases with it, and all were successful.
May 15 2020
May 14 2020
Based on discussion with Ayal, I created a quick patch to the problem of type-mismatch issue I reported above.
May 12 2020
May 11 2020
May 10 2020
The new fix delivered in this patch has caused an assert failure with a testcase having a loop with a very small trip count going through fold tail by masking.
The reduced testcase is as follows. The options are: -loop-vectorize -force-vector-interleave=4
Apr 29 2020
Feb 19 2020
Feb 12 2020
Feb 11 2020
Feb 10 2020
As pointed out by Michael @Meinersbur, the existence of an empty line between 2 blocks of #include had prevented clang-format from acting properly. I removed the empty lines, and reran clang-format on the affected files.
Based on comments from Reid @rnk and Michael @Meinersbur about IWYU, I have used the tools and adjusted removal/addition of the headers to meet the IWYU ideas. I also decided not to include the suggested llvm/IR/IntrinsicEnums.inc b/c it caused build errors.
Feb 6 2020
Feb 3 2020
Jan 31 2020
Thank you very much Hubert @hubert.reinterpretcast for your comments. I have changed the script accordingly.
Jan 30 2020
Jan 28 2020
Based on suggestion by David @dmgreen, I un-delete the headers used obviously in the files.
The change is now much smaller than that of the initial patch, but I think it is fine.
Thanks again, David! Pls let me know how you think!
Jan 27 2020
Thanks, David @dmgreen
You are right that many of the headers in my list are included transitively. Other than AssumptionCache and Dominators and Debug, can you give me names of those you like to be included explicitly even if the compilation can go without them? I will keep them untouched.
By the way, I am aware of what Whitney is working on. I am refactoring the LoopUnrollAndJam to three classes: 1. new pass manager 2. old pass manager 3. the actual implementation, which is used by both 1 and 2.
Oct 31 2019
Thank you very much Evgenii @eugenis for your prompt review and approval!
Sep 9 2019
By the end of last week, I have addressed all comments from the reviewers. Please let me know if there is any other issue, which to like me to handle so that we can complete the patch. Thank you very much!
Aug 29 2019
Address @jdoerfert Johannes's comment about not decrementing the statistics.
Aug 28 2019
My apologies about the long pause before providing this patch. I was on a long vacation, and was then driven into some other issues until now. This new patch will remove conflicting attribute, if any, currently associated with an argument before adding a read attribute to it. It also updates the statistics accordingly.
Apr 3 2019
Based on comments from the reviewers, if a pointer argument with attribute WriteOnly has no uses, there is no write through nor read from the pointer argument. In this case, its attribute can safely be strengthened from WriteOnly to ReadNone
Feb 27 2019
Feb 26 2019
Nov 16 2018
- Correct the typo on line 3707 clang/lib/Sema/SemaOpenMP.cpp
- Update the testcase: teams_distribute_simd_loop_messages.cpp