- User Since
- Nov 8 2018, 8:35 AM (135 w, 3 d)
Nov 21 2020
The error only occurs when I have more code in my local. I close it now.
Nov 20 2020
Nov 12 2020
Reopen due to a failed build on builder polly-x86_64-linux
Full details are available at:
Buildbot URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=Nr2SnYQn80wzIpml4veK2C-U4ilVZzi0kWYCc2WSLoA&m=CQgGRYR_3xNbiZpMevJ_fOqMziVnPdj-Qa8sJXA1NHQ&s=JFUUxRP6j5j0BPDw9yCc6lMViVmJFWrmcTQN13xbtEE&e=
Worker for this Build: polly-x86_64-gce1
Oct 15 2020
Address comment by Lint: Pre-merge checks related to clang-format
Oct 1 2020
Sep 16 2020
Sep 3 2020
Sep 1 2020
Aug 31 2020
Bardia and I have provided the answer to your concerns, but we have not heard from you since last week. Please let me know what other changes, if any, that you still need to see.
Aug 28 2020
Update with cl::location and remove the extra - from the testcase (eg from --disable... to -disable).
Aug 25 2020
Aug 24 2020
Thanks @bmahjour for uploading a DA test case. I had difficulty coming up with a similar test myself.
To @lebedev.ri : I think the comments from @bmahjour might have answered most of your questions. If not, please list them here and I will try to address them. If you insist in having the testcases in bugreport, I will do that. It might take some time though, since I am still waiting for my password to be reset via the webtools (contacted bugs-admin).
I saw you had again requested changes to this revision, but I could not find what changes that you thought should be required. Can you please be specific?
I removed the details about DA being confused by the insertion of memset/memcpy by LIRP in the description.
Address comments by the reviewers.
Aug 21 2020
To avoid any issue with NDA, I wrote a simple test as follows. This test program tries to prove the fact that, the impact of Loop Idiom Recognize Pass (LIGP)’s replacing store with memset is not always a positive one.
Aug 20 2020
... a concrete motivating example would be helpful.
Aug 19 2020
Remove an empty line based on reviewer's comment.
Aug 18 2020
Jul 28 2020
Jul 17 2020
Jul 10 2020
Jul 8 2020
Jun 9 2020
Jun 7 2020
Thank you very much Ayal for your suggestion. I adjusted the file accordingly.
Hello Ayal @Ayal , when you have some time, can you review this patch to the testcases, please! Thank you very much!
May 22 2020
May 19 2020
Extend pr45679-fold-tail-by-masking.ll with an additional RUN of -force-vector-width=1 and -force-vector-interleave=4 from https://reviews.llvm.org/D80085.
I write to ask if there is any thing else in this patch you like me to address. If not, please see if you could approve it. A number of testcases I am running are affected and it will be great if I can get them pass with this patch. Thank you very much!
May 17 2020
LGTM , too. Thanks for extending this feature.
May 16 2020
Similar to the 2nd patch earlier, this patch includes all the changes recommended by the reviewers.
- modified the 2nd function of the LIT test to make it clearer and simpler, and
- added ORE to confirm which pass has/does not have the impact.
This patch includes all the changes recommended by the reviewers - thank you very much!
I also added a new LIT test, which uses the ORE to confirm which pass has the impact.
In terms of testing, I have run a number of test-cases with it, and all were successful.
May 15 2020
May 14 2020
Based on discussion with Ayal, I created a quick patch to the problem of type-mismatch issue I reported above.
May 12 2020
May 11 2020
May 10 2020
The new fix delivered in this patch has caused an assert failure with a testcase having a loop with a very small trip count going through fold tail by masking.
The reduced testcase is as follows. The options are: -loop-vectorize -force-vector-interleave=4