This is an archive of the discontinued LLVM Phabricator instance.

[CGP] Remove ModifiedDT from the makeBitReverse loop
ClosedPublic

Authored by craig.topper on Aug 16 2019, 1:36 PM.

Details

Summary

I don't think anything in this loop modifies the control flow and we don't restart any iteration after setting the flag.

This code was added in http://reviews.llvm.org/D16893 but looking at the test case added there the code that caused the dominator tree to change was merging blocks with their predecessor not the bitreverse optimization.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Aug 16 2019, 1:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2019, 1:36 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
spatel accepted this revision.Aug 18 2019, 1:12 PM

LGTM

This revision is now accepted and ready to land.Aug 18 2019, 1:12 PM
This revision was automatically updated to reflect the committed changes.