Page MenuHomePhabricator

[RISCV] Convert registers from unsigned to Register
ClosedPublic

Authored by luismarques on Aug 14 2019, 1:25 PM.

Details

Summary

This patch builds upon D65962, further converting the type of register variables from unsigned to Register. The cases where unsigned remains are either in public interfaces that have not yet been converted or an oversight.

Diff Detail

Repository
rL LLVM

Event Timeline

luismarques created this revision.Aug 14 2019, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2019, 1:25 PM

Convert RISCVOperand::KindTy from an enum to an enum class, to avoid collisions with Register.

I'm pretty happy with this. Just one question to answer (below) and then it can probably be merged.

llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp
19 ↗(On Diff #215371)

Do we need this if nothing else in the file has changed?

Remove extraneous Register.h include.

luismarques marked an inline comment as done.Aug 16 2019, 5:19 AM

Updated patch, marking comment as done.

lenary accepted this revision.Aug 16 2019, 6:09 AM

LGTM!

This revision is now accepted and ready to land.Aug 16 2019, 6:09 AM
This revision was automatically updated to reflect the committed changes.