This is an archive of the discontinued LLVM Phabricator instance.

Differential D66140

[llvm-objdump] - Add a relocation-xindex-symbol.test test case.
ClosedPublic

Authored by grimar on Aug 13 2019, 6:09 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rGd4a99d87a20d: [llvm-objdump] - Add a relocation-xindex-symbol.test test case.
rL368811: [llvm-objdump] - Add a relocation-xindex-symbol.test test case.
Summary

This rewrites the exitent test case to use YAML instead of the precompiled object
and moves it from test/Object to an appropriate llvm-objdump tests folder.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Aug 13 2019, 6:09 AM
Herald added subscribers: rupprecht, arphaman. · View Herald TranscriptAug 13 2019, 6:09 AM
jhenderson accepted this revision.Aug 13 2019, 6:39 AM

LGTM.

This revision is now accepted and ready to land.Aug 13 2019, 6:39 AM
MaskRay accepted this revision.Aug 13 2019, 6:57 AM
Closed by commit rL368811: [llvm-objdump] - Add a relocation-xindex-symbol.test test case. (authored by grimar). · Explain WhyAug 14 2019, 1:33 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2019, 1:33 AM
Herald added a subscriber: seiya. · View Herald Transcript

Revision Contents

PathSize
llvm/
trunk/
test/
Object/
Inputs/
8 lines
tools/
llvm-objdump/
36 lines

Diff 215045

llvm/trunk/test/Object/Inputs/shndx.elf

  • This is a binary file.

llvm/trunk/test/Object/objdump-shndx.test

RUN: llvm-objdump -r %p/Inputs/shndx.elf | FileCheck %s
Test that llvm-objdump can handle shndx. The relocation points to a section
symbol that has st_shndx == SHN_XINDEX. To print the section name llvm-objdump
has to use the shndx section.
CHECK: RELOCATION RECORDS FOR [.text]:
CHECK-NEXT: 0000000000000000 R_X86_64_32 bar

llvm/trunk/test/tools/llvm-objdump/relocation-xindex-symbol.test

## Test that llvm-objdump can handle SHN_XINDEX. The relocation points to a section
## symbol that has st_shndx == SHN_XINDEX. To print the section name llvm-objdump
## has to use the SHT_SYMTAB_SHNDX section.
# RUN: yaml2obj %s -o %t
# RUN: llvm-objdump -r %t | FileCheck %s
# CHECK: RELOCATION RECORDS FOR [.text]:
# CHECK-NEXT: 0000000000000000 R_X86_64_32 bar
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .text
Type: SHT_PROGBITS
- Name: .rela.text
Type: SHT_RELA
Info: .text
Relocations:
- Offset: 0x0000000000000000
Symbol: bar
Type: R_X86_64_32
- Name: bar
Type: SHT_PROGBITS
- Name: .symtab_shndx
Type: SHT_SYMTAB_SHNDX
Link: .symtab
Entries: [ 0, 3 ]
Symbols:
- Name: bar
Type: STT_SECTION
Index: SHN_XINDEX