This is an archive of the discontinued LLVM Phabricator instance.

Remove no-op callbacks from TemplateInstantiationCallback
AbandonedPublic

Authored by gribozavr on Aug 13 2019, 4:23 AM.

Details

Summary

It is not clear to me that these callbacks ever did anything, they were
empty even in the original implementation (r324808).

Event Timeline

gribozavr created this revision.Aug 13 2019, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2019, 4:23 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

The changes look good to me. Added some folks who might have more knowledge about the original purpose.

Szelethus requested changes to this revision.Aug 13 2019, 7:19 AM

They are used by Templight, which we are planning to eventually move to clang-tools extra, though our resources are a bit limited at the time :)

https://github.com/mikael-s-persson/templight/blob/master/include/TemplightTracer.h
https://github.com/mikael-s-persson/templight/blob/master/lib/TemplightTracer.cpp#L306

This revision now requires changes to proceed.Aug 13 2019, 7:19 AM
gribozavr abandoned this revision.Aug 13 2019, 11:37 AM